Skip to content

Allow tab-indented EML templates - #427

Draft
funwithcthulhu wants to merge 1 commit into
camlworks:masterfrom
funwithcthulhu:temp/eml-tab-indentation
Draft

Allow tab-indented EML templates#427
funwithcthulhu wants to merge 1 commit into
camlworks:masterfrom
funwithcthulhu:temp/eml-tab-indentation

Conversation

@funwithcthulhu

Copy link
Copy Markdown
Contributor

Summary

  • Treat tabs as leading EML whitespace when detecting the start of template text.
  • Add tokenizer coverage for a tab-indented template line.

Fixes #392.

Validation

  • git diff --check
  • opam exec -- dune build src/eml/main.exe
  • opam exec -- dune build src/eml/eml.cma src/eml/eml.cmxa
  • opam exec -- dune exec src/eml/main.exe -- --stdout <tab-indented temp file>

Blocked locally:

  • opam exec -- dune runtest test/expect/eml needs ppx_expect.config_types and ppx_expect, which are not installed in this switch.
  • opam exec -- ocamlformat --check src/eml/eml.ml test/expect/eml/tokens.ml needs ocamlformat 0.25.1; this switch has 0.29.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

EML doesn’t support initial tab indentation unlike OCaml

1 participant