Require an initialization call for "Dream.memory_sessions" - #385
Merged
Conversation
Contributor
Author
|
I believe the CI failures could be fixed by merging #383. |
The initialization mechanism should make it possible to share a state among routes in "Dream.scope".
"Dream.memory_sessions" now requires an initialization call.
Willenbrink
force-pushed
the
348-scope-middleware
branch
from
February 6, 2026 14:00
08e866a to
5f8ecf0
Compare
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Dream.memory_sessionsdoesn't work properly when used withDream.scope.Proposal
This PR proposes adding one additional partial application for
Dream.memory_sessionsto make it possible to initialize its state before getting a handler.These changes should make it possible to share the session memory state with multiple routes inside a
Dream.scope.Notes
I tried first to change the function
apply(router.ml) and make it generate a unified handler usingrouterand building aroutedirectly, but I realized this function wasn't designed for nested calls since it would return a 404 response when the request doesn't match a route.