fix: Enhance build verification in CI and release workflows - #15
Merged
Conversation
- Add comprehensive checks for example site build artifacts - Verify index.html, assets directory, and CSS files exist - Add detailed error messages for missing artifacts - Prevent false positives in dry run mode - Improve library artifact verification in CI workflow This fixes the issue where dry run would pass even if the build didn't produce the expected output files.
Owner
Author
Update: Fixed Rollback Logic IssueProblem FoundThe actual release (run #3) failed because the rollback steps were incorrectly evaluating their conditions. When the publish step succeeded, the "Rollback on publish failure" step was still being evaluated and failing because it tried to rollback a successful operation. Root CauseThe rollback steps had conditions like: if: steps.publish.outcome == 'failure'But they were missing the
SolutionUpdated both rollback step conditions to: if: ${{ !inputs.dry_run && steps.push.outcome == 'failure' }}
if: ${{ !inputs.dry_run && steps.publish.outcome == 'failure' }}This ensures rollback steps only run when:
Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dry run verification in the release workflow was passing with false positives because it only checked if the
packages/example/distdirectory existed, without verifying that the build actually produced the expected output files.Solution
Enhanced both the Release and CI workflows to perform comprehensive verification:
Release Workflow
packages/example/distdirectory existsindex.htmlfile existsassetsdirectory existsCI Workflow
frostpane.css,frostpane-core.css)index.htmlfileBenefits
Testing