Change who wins when passing twice.#10
Open
cameron-martin wants to merge 2 commits into
Open
Conversation
Owner
Author
|
This causes some benchmarks to regress by 10x. This needs looking into before merging. |
cameron-martin
force-pushed
the
refactor-node-development
branch
from
May 7, 2020 14:48
25925b0 to
9997ce0
Compare
cameron-martin
changed the title
Previously, the player who did the second pass lost. However, I don't think this is correct, and this PR gives a more correct implementation.
cameron-martin
force-pushed
the
refactor-node-development
branch
from
May 9, 2020 12:31
9997ce0 to
5d064bd
Compare
cameron-martin
marked this pull request as ready for review
April 11, 2024 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the player who did the second pass lost. However, I don't think this is correct, and this PR gives a more correct implementation.