Skip to content

QoS B: update of request parameter for serviceArea#87

Open
Masa8106 wants to merge 2 commits into
camaraproject:mainfrom
Masa8106:Masa8106-AreaID
Open

QoS B: update of request parameter for serviceArea#87
Masa8106 wants to merge 2 commits into
camaraproject:mainfrom
Masa8106:Masa8106-AreaID

Conversation

@Masa8106

@Masa8106 Masa8106 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • enhancement

What this PR does / why we need it:

To update CreateBooking so that API invoker can specify an area by either id or name based on the invoker's preference. This is a proposal to align with dedicated-network-areas API which is expected to be a common area API.

Which issue(s) this PR fixes:

Fixes #86

Special notes for reviewers:

This PR will merge only after consolidating and defining our common Area API.

Changelog input

Add AreaID as requesting parameter

Additional documentation

None

@Masa8106 Masa8106 requested a review from jlurien as a code owner April 16, 2026 11:22

@jlurien jlurien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have doubts about the convenience to add this new ID having already AREANAME

Type of this area.
CIRCLE - The area is defined as a circle.
POLYGON - The area is defined as a polygon.
AREAID - The area is defined as an area ID.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently AREANAME already supports any kind of string values and it it is not limited to human friendly names. What is the benefit of having a separated AREAID for areas identified by UUIDs?

I would wait to have a more clear understanding of the Area discovery mechanisms and the possibility to have a transversal common Area APIs, and if that is the case we may refer explicitly to the equivalence of these fields in the other API.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. In my understanding, the benefit of a AREAID is to guarantee uniqueness from technical perspective.
I think it is better to keep discussion on it also with those who proposed the common Area API.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this one to draft until we have a clear understanding of the new Area API, wdyt?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not for Sync26. So it is ok for me to move it to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QoS B: update of request parameter for serviceArea

2 participants