Commonalities 8.0.0 alignment and fix validation warnings

[GillesInnov35]

Commonalities 8.0.0 alignment and fix validation warnings

What type of PR is this?

Add one of the following kinds:

• enhancement/feature

What this PR does / why we need it:

align specifications with Commonalities 8.0.0 (include common artifacts reference) and fix validation warnings

Which issue(s) this PR fixes:

Fixes #77

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

[camara-validation]

CAMARA Validation — PASS (with warnings)

0 errors, 6 warnings, 18 hints | Profile: standard

View full results

[ToshiWakayama-KDDI]

Hi @GillesInnov35 , Hi @fernandopradocabrillo ,

Thank you, Gilles, for creating this PR.

I have one comment or question. It seems that error definitions are changed to ../common/CAMARA_common.yaml#/components/responses/Generic4xx in L.210 - L.223.

However, kyc-match has some errors of its own, such as 400 KNOW_YOUR_CUSTOMER.INVALID_PARAM_COMBINATION. Therefore, we can't rely on CAMARA_common.yaml completely, and it is better for us to not delete L.534 - L.692 and keep using these error definitions.

WDYT?

[ToshiWakayama-KDDI]

Hi @GillesInnov35 , Hi @fernandopradocabrillo ,
Can we proceed with this PR quickly, as the M3 deadline has passed?

Thanks,

[maxl2287]

Please update the PR to also reference:

Fixes #80

[GillesInnov35]

@ToshiWakayama-KDDI , @rartych , rolback has been applied on Errors local definition and use to folllow meeting discussion. @ToshiWakayama-KDDI , I think we could approve and merge the PR, WDYT ?

However, kyc-match has some errors of its own, such as 400 KNOW_YOUR_CUSTOMER.INVALID_PARAM_COMBINATION. Therefore, we can't rely on CAMARA_common.yaml completely, and it is better for us to not delete L.534 - L.692 and keep using these error definitions.

[PedroDiez]

Main comments:

• info.description alignment with commonalities is needed
• Review indentation.
• Please align this PR with main, I guess many of the CAMARA validation warnings will be fixed. As per MERGED #54 and #72

[PedroDiez]

info.description field MUST be updated according to templates definition.

Reference:

• Commonalities PR: Added mandatory info.description templates to common artifacts and samples Add mandatory info.description templates to common artifacts and samples Commonalities#635
• Commonalities Reference (same info, expressed in terms of metarelease): https://github.com/camaraproject/Commonalities/blob/r4.3/artifacts/common/info-description-templates.yaml

[PedroDiez]

Please take a look to this comment: #80 (comment)

[ToshiWakayama-KDDI]

Thanks, @GillesInnov35 , @PedroDiez .

@GillesInnov35 , LGTM, so I think I can approve the PR. Are there still remaining issues you are thinking of addressing? Also there seem to be conflicts. I think that is because of PR #72 updates. Can you resolve it?

Many thanks,
Toshi