You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
2. Design — needs rework before review
Two endpoints (/tac/{trackingAreaCode} and the plmn filter) expose internal 3GPP network parameters (Tracking Area Code, PLMN) directly to the API consumer. These are not northbound-portable identifiers — a developer has no way to obtain a TAC, and exposing it leaks internal network topology, which goes against CAMARA's abstraction principle. Please redesign around a developer-facing identifier: device object or phoneNumber (per CAMARA_common.yaml) for the device-centric use case, and a standard geographic area object for the location-centric use case.
3. Other Commonalities gaps
No security scheme defined (securitySchemes/security) — needed before ICM/personal-data review can even start
Subscription model (/subscribe, /subscriptions/{id}) doesn't follow the CAMARA event subscription pattern (CloudEvents / CAMARA_event_common.yaml) — should be aligned to it
Once the template, CLA, and slides are in place, and the TAC/PLMN exposure is resolved, happy to do a full layer-by-layer review of the spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement/feature
What this PR does / why we need it:
New proposal for network outage API
Which issue(s) this PR fixes:
Fixes #327
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.