bump twine to 7.0.0 to support Core Metadata 2.5 (PEP 794) - #370
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate plumbing/utils pinned dependencies to use twine 7.0.0 (which supports Core Metadata 2.5 / PEP 794) and align its direct transitive dependencies accordingly, along with updating the pip-compile Python version header comment. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The requirements header now indicates generation with Python 3.12; please confirm this matches the actual environment used for pip-compile to avoid subtle cross-version resolution differences.
- With the twine bump to 7.0.0, consider reviewing any existing twine CLI invocations in this repo to ensure no deprecated or removed flags/behaviors are relied upon.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The requirements header now indicates generation with Python 3.12; please confirm this matches the actual environment used for pip-compile to avoid subtle cross-version resolution differences.
- With the twine bump to 7.0.0, consider reviewing any existing twine CLI invocations in this repo to ensure no deprecated or removed flags/behaviors are relied upon.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
flit_core 4.0.1 (released 2026-08-04) emits the new Import-Name metadata field from PEP 794. twine 6.2 + packaging 25.0 reject it with "InvalidDistribution: unrecognized or malformed field 'import-name'", breaking every release whose build dependencies include flit_core >=4. twine 7.0.0 requires packaging >=26.1 and handles metadata version 2.5 end-to-end.
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flit_core 4.0.1was released on PyPI and it's the first version to use the new Import-Name metadata field (PEP 794). Since Fromager has no version cap, it gets pulled in as a build dep for basically everything. Our twine (6.2) doesn't understand that field and rejects the upload. To fix this, we need to bump twine to 7.0 in plumbing/utilsSummary by Sourcery
Bump the twine dependency in the utils plumbing to version 7.0.0 to support newer core metadata, refreshing its related requirements.
Enhancements: