Skip to content

bump twine to 7.0.0 to support Core Metadata 2.5 (PEP 794) - #370

Merged
ronnll merged 1 commit into
mainfrom
CALUNGA-399
Aug 4, 2026
Merged

bump twine to 7.0.0 to support Core Metadata 2.5 (PEP 794)#370
ronnll merged 1 commit into
mainfrom
CALUNGA-399

Conversation

@ronnll

@ronnll ronnll commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

flit_core 4.0.1 was released on PyPI and it's the first version to use the new Import-Name metadata field (PEP 794). Since Fromager has no version cap, it gets pulled in as a build dep for basically everything. Our twine (6.2) doesn't understand that field and rejects the upload. To fix this, we need to bump twine to 7.0 in plumbing/utils

Summary by Sourcery

Bump the twine dependency in the utils plumbing to version 7.0.0 to support newer core metadata, refreshing its related requirements.

Enhancements:

  • Update utils requirements lockfile to reflect regeneration with Python 3.12.
  • Refresh transitive dependencies of twine, including packaging and rich, to compatible newer versions.

@sourcery-ai

sourcery-ai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update plumbing/utils pinned dependencies to use twine 7.0.0 (which supports Core Metadata 2.5 / PEP 794) and align its direct transitive dependencies accordingly, along with updating the pip-compile Python version header comment.

File-Level Changes

Change Details Files
Bump twine to 7.0.0 to support Core Metadata 2.5 (PEP 794) and refresh its related pins.
  • Update the pinned twine version from 6.2.0 to 7.0.0 with new hash values in the autogenerated requirements file.
  • Update the pinned packaging dependency to 26.3 with corresponding hashes, reflecting twine’s newer dependency constraints.
  • Update the pinned rich dependency to 15.0.0 with corresponding hashes, matching the dependency set required by twine 7.0.0.
  • Adjust the header comment in the autogenerated requirements file to reflect that it is now generated with Python 3.12 instead of Python 3.14.
utils/requirements.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The requirements header now indicates generation with Python 3.12; please confirm this matches the actual environment used for pip-compile to avoid subtle cross-version resolution differences.
  • With the twine bump to 7.0.0, consider reviewing any existing twine CLI invocations in this repo to ensure no deprecated or removed flags/behaviors are relied upon.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The requirements header now indicates generation with Python 3.12; please confirm this matches the actual environment used for pip-compile to avoid subtle cross-version resolution differences.
- With the twine bump to 7.0.0, consider reviewing any existing twine CLI invocations in this repo to ensure no deprecated or removed flags/behaviors are relied upon.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

flit_core 4.0.1 (released 2026-08-04) emits the new Import-Name
metadata field from PEP 794. twine 6.2 + packaging 25.0 reject it
with "InvalidDistribution: unrecognized or malformed field
'import-name'", breaking every release whose build dependencies
include flit_core >=4. twine 7.0.0 requires packaging >=26.1 and
handles metadata version 2.5 end-to-end.
@ronnll
ronnll merged commit e0816fa into main Aug 4, 2026
4 checks passed
@ronnll
ronnll deleted the CALUNGA-399 branch August 4, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant