Red Hat Konflux kflux-prd-rh03 update wheel-check-scripts - #366
Open
red-hat-konflux-kflux-prd-rh03[bot] wants to merge 2 commits into
Open
Red Hat Konflux kflux-prd-rh03 update wheel-check-scripts#366red-hat-konflux-kflux-prd-rh03[bot] wants to merge 2 commits into
red-hat-konflux-kflux-prd-rh03[bot] wants to merge 2 commits into
Conversation
Signed-off-by: red-hat-konflux-kflux-prd-rh03[bot] <206760901+red-hat-konflux-kflux-prd-rh03[bot]@users.noreply.github.com>
Reviewer's GuideThis PR introduces Konflux Pipelines-as-Code PipelineRun definitions for the wheel-check-scripts component, covering both pull request validation and main-branch push builds using trusted-artefact-based buildah pipelines and standard Konflux security/compliance tasks. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The pull-request and push PipelineRuns are nearly identical; consider extracting the shared pipelineSpec into a reusable Pipeline (or common template) to reduce duplication and simplify maintenance when task bundles or parameters change.
- The on-cel-expression filters use the same pathChanged patterns for both PipelineRuns; if there are other wheel-check-related files (e.g., configs or supporting scripts) that should trigger a build, it may be worth reviewing and adjusting these patterns now to avoid missing relevant changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The pull-request and push PipelineRuns are nearly identical; consider extracting the shared pipelineSpec into a reusable Pipeline (or common template) to reduce duplication and simplify maintenance when task bundles or parameters change.
- The on-cel-expression filters use the same pathChanged patterns for both PipelineRuns; if there are other wheel-check-related files (e.g., configs or supporting scripts) that should trigger a build, it may be worth reviewing and adjusting these patterns now to avoid missing relevant changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content
/ok-to-testFor more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization
Please follow the block sequence indentation style introduced by the proprosed PipelineRuns YAMLs, or keep using consistent indentation level through your customized PipelineRuns. When different levels are mixed, it will be changed to the proposed style.
Summary by Sourcery
Add Tekton Pipelines as Code PipelineRuns for building and checking the wheel-check-scripts container image on pull requests and pushes to main.
Build:
CI: