Skip to content

Red Hat Konflux kflux-prd-rh03 update wheel-check-scripts - #366

Open
red-hat-konflux-kflux-prd-rh03[bot] wants to merge 2 commits into
mainfrom
konflux-wheel-check-scripts
Open

Red Hat Konflux kflux-prd-rh03 update wheel-check-scripts#366
red-hat-konflux-kflux-prd-rh03[bot] wants to merge 2 commits into
mainfrom
konflux-wheel-check-scripts

Conversation

@red-hat-konflux-kflux-prd-rh03

@red-hat-konflux-kflux-prd-rh03 red-hat-konflux-kflux-prd-rh03 Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Please follow the block sequence indentation style introduced by the proprosed PipelineRuns YAMLs, or keep using consistent indentation level through your customized PipelineRuns. When different levels are mixed, it will be changed to the proposed style.

Summary by Sourcery

Add Tekton Pipelines as Code PipelineRuns for building and checking the wheel-check-scripts container image on pull requests and pushes to main.

Build:

  • Introduce pull-request PipelineRun configuration to build and validate wheel-check-scripts images with Konflux trusted-artifacts pipeline.
  • Introduce push PipelineRun configuration to build, tag, and publish wheel-check-scripts images on main branch updates using Konflux build pipeline.

CI:

  • Configure Pipelines as Code triggers for pull_request and push events, scoped to wheel-check-scripts sources, Containerfile, and Tekton configs.

Signed-off-by: red-hat-konflux-kflux-prd-rh03[bot] <206760901+red-hat-konflux-kflux-prd-rh03[bot]@users.noreply.github.com>
@sourcery-ai

sourcery-ai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Reviewer's Guide

This PR introduces Konflux Pipelines-as-Code PipelineRun definitions for the wheel-check-scripts component, covering both pull request validation and main-branch push builds using trusted-artefact-based buildah pipelines and standard Konflux security/compliance tasks.

File-Level Changes

Change Details Files
Add a pull-request PipelineRun that builds and validates the wheel-check-scripts container image when relevant files change.
  • Define metadata annotations and labels to integrate with AppStudio/Konflux and Pipelines as Code for pull_request events on main with path-change filters
  • Configure parameters for git source, revision, output image (on-pr tag), dockerfile, and build context under tasks/scripts/wheel-check
  • Embed an inlined pipelineSpec that uses Konflux catalog bundles for init, git-clone with OCI storage, dependency prefetch, buildah-based container build, image index creation, optional source image build, and multiple security/compliance and SAST tasks
  • Set workspaces and taskRunTemplate service account, with an optional image expiration parameter and OCI artifact storage suffixes for git and prefetch data
.tekton/wheel-check-scripts-pull-request.yaml
Add a push PipelineRun that builds and validates the wheel-check-scripts container image on main-branch pushes with nearly identical trusted build and check stages.
  • Define metadata annotations and labels for push events on main with path-change filters and no in-progress cancellation
  • Configure parameters for git source, revision, output image (commit-tagged), dockerfile, and build context, largely mirroring the pull-request PipelineRun
  • Reuse the same Konflux catalog tasks for init, git clone, prefetch, buildah build, image index, optional source image build, and the suite of security/compliance and SAST checks, plus tag application and Dockerfile push as OCI artifact
  • Set workspaces and taskRunTemplate to use the build-pipeline-wheel-check-scripts service account and git-auth secret, maintaining consistent trusted-artifact flow
.tekton/wheel-check-scripts-push.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The pull-request and push PipelineRuns are nearly identical; consider extracting the shared pipelineSpec into a reusable Pipeline (or common template) to reduce duplication and simplify maintenance when task bundles or parameters change.
  • The on-cel-expression filters use the same pathChanged patterns for both PipelineRuns; if there are other wheel-check-related files (e.g., configs or supporting scripts) that should trigger a build, it may be worth reviewing and adjusting these patterns now to avoid missing relevant changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The pull-request and push PipelineRuns are nearly identical; consider extracting the shared pipelineSpec into a reusable Pipeline (or common template) to reduce duplication and simplify maintenance when task bundles or parameters change.
- The on-cel-expression filters use the same pathChanged patterns for both PipelineRuns; if there are other wheel-check-related files (e.g., configs or supporting scripts) that should trigger a build, it may be worth reviewing and adjusting these patterns now to avoid missing relevant changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
@smatula

smatula commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant