fix(builder): add ftp.gnu.org fallback for GNU source downloads - #361
Open
vbelouso wants to merge 1 commit into
Open
fix(builder): add ftp.gnu.org fallback for GNU source downloads#361vbelouso wants to merge 1 commit into
vbelouso wants to merge 1 commit into
Conversation
Reviewer's GuideAdds a fallback mechanism for GNU source downloads in the builder scripts to improve resilience against bad TLS on ftpmirror.gnu.org, wires the new fallback into GNU-related install scripts and the Containerfile, tweaks Arrow build flags for x86_64, and slightly increases the CI test job timeout. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new fetch_source fallback logic hardcodes preferred_attempts and fallback_attempts to 3; consider making these configurable (e.g., via environment variables) so you can tune retry behavior without changing the script.
- In fetch_source, all status messages (including failures and the final 'Both preferred and fallback sources failed') currently go to stdout; routing error-related logs to stderr would make it easier to distinguish build noise from actual failures in CI logs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new fetch_source fallback logic hardcodes preferred_attempts and fallback_attempts to 3; consider making these configurable (e.g., via environment variables) so you can tune retry behavior without changing the script.
- In fetch_source, all status messages (including failures and the final 'Both preferred and fallback sources failed') currently go to stdout; routing error-related logs to stderr would make it easier to distinguish build noise from actual failures in CI logs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
vbelouso
force-pushed
the
fix/gnu-mirror-fallback
branch
from
July 27, 2026 17:27
09826c7 to
f787d71
Compare
vbelouso
force-pushed
the
fix/gnu-mirror-fallback
branch
from
July 27, 2026 17:30
f787d71 to
eb0e931
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ftpmirror.gnu.orgoccasionally redirects to a backend with an expired TLS certificate.curl --retrydoes not retry SSL errors (exit 60), so the build fails even though the artifact is available elsewhere.fetch_sourcenow accepts an optional fallback URL. When provided, the preferred source is triedpreferred_attempts=3times (shell loop, retries any curl error). On exhaustion it falls back to the canonical URL with the same retry policy. Without a fallback the existing--retry 10behaviour is unchanged.Containerfile exports
AUTOCONF/AUTOMAKE/LIBTOOL_FALLBACK_URL=https://ftp.gnu.org/gnu/...for the three affected packages.