Skip to content

Onboard presidio-analyzer - #5537

Open
vbelouso wants to merge 1 commit into
calungaproject:mainfrom
vbelouso:onboard/presidio-analyzer
Open

Onboard presidio-analyzer#5537
vbelouso wants to merge 1 commit into
calungaproject:mainfrom
vbelouso:onboard/presidio-analyzer

Conversation

@vbelouso

@vbelouso vbelouso commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Onboard presidio-analyzer at version 2.2.359

Summary by Sourcery

New Features:

  • Add configuration for the presidio-analyzer package at version 2.2.359 to the onboarded packages list.

@sourcery-ai

sourcery-ai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Onboards the presidio-analyzer package by adding its metadata JSON to the onboarded_packages directory at version 2.2.359.

File-Level Changes

Change Details Files
Add onboarding metadata for presidio-analyzer at version 2.2.359.
  • Create a new JSON manifest describing the presidio-analyzer package.
  • Specify the package name, version, and any required onboarding metadata fields in the JSON file so it can be recognized by the onboarding pipeline.
onboarded_packages/presidio-analyzer.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@vbelouso
vbelouso force-pushed the onboard/presidio-analyzer branch from 253eb13 to 863fffd Compare July 15, 2026 06:43
@jvulgan

jvulgan commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@jvulgan jvulgan added the pkg onboarding Package onboarding PRs label Jul 15, 2026
@jvulgan

jvulgan commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@vbelouso can you please rebase your PR onto latest main? There is an issue with the identify-packages step resulting in incorrect output if the PR branch is stale. I've created https://redhat.atlassian.net/browse/CALUNGA-379 for script to handle it better

Generated-by: Claude Code
@vbelouso
vbelouso force-pushed the onboard/presidio-analyzer branch from 863fffd to 67fb90a Compare July 15, 2026 09:06
@vbelouso

Copy link
Copy Markdown
Contributor Author

@vbelouso can you please rebase your PR onto latest main? There is an issue with the identify-packages step resulting in incorrect output if the PR branch is stale. I've created https://redhat.atlassian.net/browse/CALUNGA-379 for script to handle it better

Done

@jvulgan

jvulgan commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@jvulgan

jvulgan commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@smatula can you check what's going on here? The integration tests are failing:

presidio_analyzer-2.2.359-0-py3-none-any.whl                 FAIL     import failures
  -> presidio_analyzer: ImportError: No module named 'click'
  spacy-3.8.13-0-cp312-cp312-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl FAIL     import failures
  -> spacy: ImportError: No module named 'click'
  weasel-1.0.0-0-py3-none-any.whl                              FAIL     import failures
  -> weasel: ImportError: No module named 'click'

But if you check what wheels were build, click is there. Seems like it's not being correctly included in the install tiers.

@smatula

smatula commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@jvulgan Yes, Two groups were skipped in phase 2 fallback because of name parsing issue. Working on fix.

@jvulgan

jvulgan commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg onboarding Package onboarding PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants