Fix: Kanban "Hide empty columns" ignored when swimlanes are enabled#2019
Open
scottTomaszewski wants to merge 3 commits into
Open
Fix: Kanban "Hide empty columns" ignored when swimlanes are enabled#2019scottTomaszewski wants to merge 3 commits into
scottTomaszewski wants to merge 3 commits into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
"Hide empty columns" had no effect in the Kanban view when swimlanes were enabled. Flat (no-swimlane) mode filters each column through
shouldRenderKanbanColumninrenderFlat, but the swimlane path (renderWithSwimLanes→renderSwimLaneTable) rendered every column key unconditionally, so emptied columns stayed visible in both the header row and every swimlane row.getVisibleKanbanSwimLaneColumnKeystokanbanGrouping.ts, which uses the existinggetKanbanColumnTaskCountsto total each column across all swimlanes and drops columns that are empty (and not pinned) when "Hide empty columns" is on.renderWithSwimLanes, passing the filtered column keys torenderSwimLaneTable. Counts are taken from the post-filterswimLanesmap so they reflect the active filter; pinned columns are preserved, matching flat-mode behavior.Test Plan
tests/unit/bases/kanbanGrouping.test.ts(hides empty columns, keeps empty pinned columns, keeps all columns when the option is off).tests/unit/issues/issue-kanban-hide-empty-columns-swimlanes.test.tscovering the build-groups → build-swimlanes → filter pipeline.tsc --noEmitpasses.Reproduction
Resolves #2018