Skip to content

refactor(move): move managed device allocation into its own workspace package (#2316) - #2321

Merged
thymikee merged 2 commits into
mainfrom
refactor/2316-managed-allocation-package
Sep 6, 2026
Merged

refactor(move): move managed device allocation into its own workspace package (#2316)#2321
thymikee merged 2 commits into
mainfrom
refactor/2316-managed-allocation-package

Conversation

@thymikee

@thymikee thymikee commented Sep 5, 2026

Copy link
Copy Markdown
Member

Summary

Moves src/daemon/managed-device-allocation/ (27 production modules) into a new private workspace package packages/managed-allocation (@agent-device/managed-allocation). It exposes eight boundary entry points — decision, fence, journal, record, schema, status, store, transitions — and keeps the codec, journal-lane, and store-filesystem internals private. No behavior change: a pure move with import re-points, plus three shape adjustments the gates require:

  • a record-types.ts leaf splits the record-model types so the entry does not close a type cycle (R10);
  • bindingFenceFor moves to the non-entry record-fence.ts so the record and decision entries stay under the ADR-0019 eager-closure ceilings;
  • capture-kit declares a ./durable-json subpath so the record codec/validation modules do not evaluate the full capture-kit barrel.

Closes #2316

Validation

Validated at d5f18b6a14:

  • pnpm typecheck — green
  • pnpm vitest run packages/managed-allocation src/__tests__/managed-device-allocator-fake.test.ts src/managed-device-reachability.test.ts src/daemon/__tests__/atomic-publish-ownership.test.ts — 47/47 pass
  • pnpm check:layering — green (R11: 20 packages / 216 exported subpaths)
  • pnpm check:production-exports — 52 issues · 18 suppressed · 0 stale
  • pnpm check:fallow — no issues in 45 changed files
  • pnpm build — 401 files / 3.77 MB, identical to the merge-base baseline
  • pnpm check:affected --run — all runnable checks pass, including the ADR-0019 eager-closure budgets

Gross diff: 45 files; rename-heavy move with no material content change.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-06 05:32 UTC

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.48 MB 4.48 MB +83 B
Package (unpacked) 4.48 MB 4.48 MB +83 B
Package (download) 1.33 MB 1.33 MB +15 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 23.6 ms 22.7 ms -0.8 ms
CLI --help 66.8 ms 62.4 ms -4.4 ms

@thymikee

thymikee commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

Sentinel at d5f18b6: clean coordinator + independent Terra/high review against 80997b6. The issue-scoped allocation package move preserves journal/store/codec/transition behavior, keeps internal modules private, and exposes the requested eight subpaths without root shims. Record/fence splits avoid unnecessary eager imports; package growth is +83 B. Coverage, Integration and other completed checks pass; iOS smoke is still running, so this is ready for human review, not yet CI-complete merge readiness. No new device behavior requires separate live proof for this move. Land the package boundary before dependent managed-stack work is restacked/repointed; retain explicit daemon request-binding vs package-mechanics ownership. No fixes or merge performed.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 5, 2026
@thymikee

thymikee commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

Sentinel CI reconciliation at unchanged d5f18b6: the remaining iOS smoke passed. All 20 runnable checks now succeed (one skipped); the existing clean review and ready-for-human label remain valid. Merge-ready, with the previously noted dependent-stack restack/repointing requirement after this package move. No merge performed.

@thymikee
thymikee merged commit e0f8c55 into main Sep 6, 2026
21 checks passed
@thymikee
thymikee deleted the refactor/2316-managed-allocation-package branch September 6, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(daemon): move managed device allocation into its own workspace package

1 participant