docs(agents): PR diff budget, move PRs, gates commit, validation lifecycle

[thymikee]

Summary

Adds durable PR guidance for:

• a 1,000-line gross diff budget, with a narrow rename-only exception;
• implementation-first commit shape with enforcement edits isolated in a final chore(gates): ... commit;
• exact-head validation evidence and a 250-word PR-body limit;
• focused red/green checks followed by one successful full affected gate;
• regression coverage at the seam missed by an earlier PR.

Also keeps run- or commit-stamped benchmark output out of scripts/ and records the general no-unit-retry policy. Volatile Vitest project membership and scheduling state remain owned by vitest.config.ts, rather than being duplicated in procedural guidance.

Validation

• Tested commit 572572e470.
• Fresh pnpm install --frozen-lockfile and pnpm build succeeded.
• pnpm format:check passed.
• pnpm check:affected --run passed; the selected agent-guidance contract was 4/4 green.
• No planted-red evidence applies because this is a docs-only policy change.

[thymikee]

BLOCKED at f5c90988a8f962ea7eda979702509f28892c76db.

1. The 1,000-line budget and -M90% move proof use two-dot git diff ... origin/main, which compares endpoint trees and can count unrelated main advances despite the preceding no-rebase rule. Use origin/main...HEAD or an explicit merge base.

2. Testing guidance says SUBPROCESS_STUB_TESTS run un-serialized in unit-core, but current vitest.config.ts defines a dedicated subprocess-stub project with fileParallelism: false and maxWorkers: 1. Correct the lane/concurrency guidance.

3. Validation says pnpm check:affected --run is pending although the new lifecycle requires it before push. Provide exact-head evidence or revise the rule coherently.

Exact-head docs checks are green and no device evidence is owed, but these findings block readiness.

[thymikee]

Addressed at 72b7564a6f2043e1b7ec78e409ffe037ab659f06 (rebased onto main 8021503, clean).

1. Budget and move proof now use three-dot git diff --stat origin/main...HEAD and git diff -M90% --stat origin/main...HEAD, with the merge-base-to-head meaning stated inline.

2. vitest.config.ts at this head (identical to origin/main) defines no subprocess-stub project: SUBPROCESS_STUB_TESTS (lines 14–22) is a list whose members run in unit-core's default forks pool (comment lines 5–13, include at 108–111); the only serialized project is fuzz-worker (lines 204–209: fileParallelism: false, maxWorkers: 1). The finding matches an older config; testing.md now states these facts and cites the file.

3. Lifecycle rule revised: the full pnpm check:affected --run is owed on the exact pushed head, run locally or by a serialized gate stage that appends the exact-head result to the PR body. That gate result for this head follows from the gate stage. check:agent-guidance and format:check are green on this head.

[thymikee]

BLOCKED at 72b7564a6f2043e1b7ec78e409ffe037ab659f06.

The merge-base diff and exact-head affected-gate evidence are corrected; selected checks are green. However, the testing guidance and PR summary falsely say no subprocess-stub project exists and the tests run un-serialized in unit-core. At this head, vitest.config.ts excludes SUBPROCESS_STUB_TESTS from unit-core and defines a dedicated subprocess-stub project with fileParallelism: false, isolate: true, and maxWorkers: 1. Correct the docs to the actual serialized lane; do not label ready.

[thymikee]

Resolved at 572572e4708a821581cc264c4565067922338b4f. Correction to the prior blocker: the exact PR head did not contain a serialized subprocess-stub project; that finding was based on the wrong tree. To avoid this class of drift, volatile project membership and scheduling prose is now removed from procedural guidance and remains owned by vitest.config.ts. The durable no-retry and benchmark-output policies remain. Fresh install/build, formatting, and the selected agent-guidance affected gate pass. Exact-head GitHub checks are running.

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-03 13:07 UTC