refactor(layering): one retired-paths rule for src/utils and src/replay - #2240
Merged
Conversation
R14 (src-utils-retirement) and R71 (replay-ownership) were the same path-prefix denylist instantiated in two modules. Fold both into scripts/layering/retired-paths-policy.ts, driven by a table keyed by rule id; ids, messages, inputs (tracked src/utils paths vs production sources) and check.ts wiring are unchanged.
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. Top changed packed filesNo changed packed files. |
Member
Author
|
READY — clean review at this exact head. R14/R71 retain their exact identities, messages, inputs and wiring; the shared retired-path owner preserves the original behaviors and the planted regressions exercise both real tracked zones. Deleted modules have no consumers and all exact-head CI is green. No code findings. The PR body still lists the local full affected gate as pending, but GitHub’s code-owning lanes are complete. |
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layering rules R14 (
src-utils-retirement) and R71 (replay-ownership) were the same predicate, a path-prefix denylist for a retired directory, written twice in two modules with two tests. They now live in one module,scripts/layering/retired-paths-policy.ts, driven by a table keyed by rule id (R14,R71) that holds the retired prefix and the owner guidance. Adding a retired directory is one table row.Gate behavior is unchanged: both rule ids, both messages, and both inputs survive as-is (R14 still scans every tracked path under
src/utils, including the exact root entry; R71 still scans production sources undersrc/replay/).check.tskeeps its keyed rule record and reporting order.rule-ids.tsstill sees each id declared exactly once as a whole literal.6 files touched, all under
scripts/layering/; no fallow baseline entries referenced the deleted modules.Validation
pnpm check:layering(folded test file plusrule-idsandcheck-wiringtests, then the guard): green, 1579 source files.pnpm check:quick,pnpm format:check,pnpm check:fallow: green.src/utils/planted.tsandsrc/replay/planted.tsstaged, thennode --experimental-strip-types scripts/layering/check.ts(exit 1):::error file=src/utils/planted.ts,line=1,title=Layering drift (R14 src-utils-retirement)::src/utils is retired; move this path to its owning package or command zone::error file=src/replay/planted.ts,line=1,title=Layering drift (R71 replay-ownership)::src/replay/ is retired; caller source acquisition belongs under src/commands/replay/ and replay-test presentation belongs under src/cli/replay-test/.Planted files removed afterwards.