chore(gates): drop the test-file size pin map, keep the merge-base ratchet - #2238
Merged
Conversation
…tchet The exact-length pin map duplicated what the merge-base already records and made every shrink a two-file edit. The gate now has one rule: a test file over the 1,000-line tripwire may be no longer than at the merge-base with origin/main, and no new test file may cross the tripwire.
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. Top changed packed filesNo changed packed files. |
Member
Author
|
READY — clean review at this exact head. The merge-base test-file ratchet remains fail-closed for growth, threshold crossings, renames, and new/untracked giant tests; shrink-without-pin-edit is correctly allowed. The planted red/green evidence exercises the real Git-backed gate, docs match, and all exact-head CI is green. No code findings. |
thymikee
added
the
ready-for-human
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The test-file size gate had two rules: an exact-length pin map for every test file over 1,000 lines, and a history-backed rule against the merge-base. The pin map duplicated what git already records and turned every shrink into a two-file edit. This drops the pin map and the three assertions that served only it (pin equals file, pin not above base, pin-list-empty kill criterion).
Gate behavior for test authors now:
origin/main.Kill criterion: no test file under the walked roots exceeds the tripwire at the merge-base; delete the gate when that holds.
docs/agents/testing.mdno longer mentions pins; a stale citation ineager-closure-budgets.tsnaming this gate as an equality-pin example is removed. Nothing else importedPINNED_TEST_FILE_LINES.Validation
Focused:
npx vitest run --project unit-core scripts/__tests__/test-file-size-ratchet.test.ts(3 passed),pnpm check:quick,pnpm check:gate-manifest,pnpm check:fallow, all clean at 63ed6a2.Planted red: a scratch commit appending 3 lines to
src/__tests__/cli-network.test.ts, same vitest command:Planted green: a scratch commit deleting 3 lines from that file, no gate edit, passed 3/3. Both scratch commits were discarded before push.
Full affected gate: pending (serialized gate stage will append the result)