You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Retire the final src/platforms seam and move the remaining cross-family install-source tests to their root test owner.
Remove the obsolete R3 folder policy and dead affected-test routing. R13 remains the concrete package import owner, while a new all-file retirement gate prevents the old root from returning.
Update ADR 0019 and the dependency-graph findings to record the completed physical ownership boundary, Apple’s named facades, and the durable R13/R65 split.
Planted red: the terminal boundary test accepted a tracked file under src/platforms before the implementation.
pnpm check:affected --run — all runnable checks passed after rebasing onto merged main.
Focused policy/model suite: 82 tests passed.
Vitest related: 2 files / 414 tests passed.
Layering graph: 1,522 files, 0 value cycles, 0 spine backedges, and no platforms zone.
Adversarial review and worker-diff reconciliation resolved a non-TypeScript fixture blind spot, stale path-ownership language, and missing Apple facade documentation.
Reviewed exact head b6de3b6e77 as the stack child of #2118.
P1 — the retirement gate misses an exact tracked src/platforms entry.git ls-files -- src/platforms can return the root path itself when it is a tracked file, symlink, or gitlink, but checkRetiredPlatformsZone only rejects strings beginning src/platforms/. Include file === 'src/platforms' and plant that exact-root case so the claimed terminal boundary is complete.
P2 — ADR 0019 still contradicts the enforced Apple export surface. It says Apple exposes its root plus exactly ./runner, ./runner/client, and ./runner/test-host, while refactor: move Apple platform family into package #2118/R13 now enforce eighteen exports with many domain facades. Scope that sentence to the runner facet or point accurately to the complete R13 declaration.
Otherwise the empty old tree, moved cross-family tests, coverage pointer, stack base, and completed CI checks look good. The PR body’s retarget note is also stale; iOS smoke remains pending.
Structural/code review is clear on exact head b2c9d5db2e7b363b248a58fd0e378037c36f3f50: it retires the final tracked src/platforms paths, rejects any future production/test/fixture file under that root, and preserves R13/R65 ownership without changing command identity or runtime behavior. The change is net-negative and no materially smaller safe design stood out.
I cannot mark it merge-ready because exact-head iOS Smoke is red (TEXT_INPUT_COMMIT_NOT_OBSERVED in seed email field). The diff does not touch that route, but the required check needs a successful rerun or documented disposition first.
The failed iOS job was rerun against exact head b2c9d5d and is now green. The previously failing fixture-backed simulator E2E step passed, along with the remaining iOS smoke coverage. The stale CI blocker is cleared.
Re-verified exact head b2c9d5db2e7b363b248a58fd0e378037c36f3f50: all checks are now green, including the rerun iOS Smoke. No code or readiness blocker remains. The structural review is unchanged—this safely retires the final src/platforms root while preserving R13/R65 ownership and public/runtime behavior. As the clean bottom of the #2123 → #2125 stack, it is ready for human review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retire the final
src/platformsseam and move the remaining cross-family install-source tests to their root test owner.Remove the obsolete R3 folder policy and dead affected-test routing. R13 remains the concrete package import owner, while a new all-file retirement gate prevents the old root from returning.
Update ADR 0019 and the dependency-graph findings to record the completed physical ownership boundary, Apple’s named facades, and the durable R13/R65 split.
Closes #2082
Validation
src/platformsbefore the implementation.pnpm check:affected --run— all runnable checks passed after rebasing onto mergedmain.platformszone.