refactor: move W6 platform families behind package facades - #2116
Conversation
|
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks:
Top changed packed files
|
|
Re-reviewed P1: exact-head Coverage proves four real eager-load regressions: P1 architecture: #2082 assigns Scope: #2082’s maintainer triage says the umbrella is not executable and each wave needs a child issue; none is linked, so W6 needs that child or explicit authorization. Size CI is +9.1 kB npm unpacked; add ADR 0019 §8 root-bytes-removed/package-bytes-added accounting, each growth cause, and the rejected smaller design. iOS Smoke’s zero-readable-capture wait looks unrelated but needs a green rerun; exact-head live HarmonyOS/Vega/Web evidence is also still absent. |
|
Addressed in
|
|
Reviewed b5dd30f as the W6 foundation for the #2082 W4-W6 family. Standalone code review and all exact-head checks are clean after the host-file/snapshot-seam fixes, but I am not marking it ready independently because the current sibling heads are not cohesively landable. Required family landing plan:
Exact live HarmonyOS/Vega/Web provider evidence is still unclaimed, so that remains required family validation. No code finding is outstanding on this head itself; this is a family sequencing/evidence blocker. |
|
Thanks — acknowledged. There is no outstanding code finding on I updated the PR description with the family landing/evidence state. I’m keeping this task narrowly on W6: I will not mutate #2117/#2118 or absorb their W4/W5 code. The required order is therefore #2116 first, then #2117 rebased onto it, then #2118 rebased onto both, followed by combined-family validation by the owning work. Exact-head live HarmonyOS/Vega/Web provider evidence remains unclaimed and is a family readiness blocker. No merge was performed. |
b5dd30f to
4eec054
Compare
|
Update: GitHub reported this PR as conflicting with The post-rebase local No W4/W5 sibling work was changed, no live HarmonyOS/Vega/Web evidence is being claimed, and no merge was performed. |
|
Re-reviewed exact head 4eec054: it is a pure rebase of previously reviewed b5dd30f with no logical code delta; completed checks are green and one smoke lane remains pending. No code finding on this head, but do not mark independently ready: current main is two commits ahead, #2117 must be truly restacked onto this published head, #2118 remains conflicting and lands last, and combined-family plus live HarmonyOS/Vega/Web evidence is still required. |
4eec054 to
b3c8c67
Compare
Summary
Implements W6 of #2082 for HarmonyOS, Linux, Vega, and Web:
src/platformsinto its private platform package;host-kit, including a separatehost-fileentry point so existinghost-kit/fileconsumers retain their eager-load baseline;Per-family adversarial review:
No W4, W5, or W7 implementation is included. The W6 scope is explicitly authorized by the current implementation task; #2082 remains the coordination umbrella. Refs #2082
Validation
host-kit/file12→13,provision-kit/install-source25→26,src/cli.ts381→382, andsession-teardown68→69.pnpm typecheck,pnpm check:layering(159 tests plus the global scan), build, package clean-install closure, and Node integration smoke (90 passed / 9 live tests skipped).pnpm check:affected --runselected 56 checks and reached the related Vitest lane. 499 files / 3,971 tests passed; two unrelated 5-second tests timed out only under the 501-file concurrent suite. Both passed in isolation: gesture-admission parity 4/4 and scripted-provider iOS lifecycle 3/3. No local check result is being overstated as a full-gate pass.src/platforms= 154,071 B; 36 relocated production files plus four package facades = 171,259 B in the platform-package targets; source-tree delta = +17,188 B. The follow-up host-authority facade adds 430 B as a separate package-only seam and does not duplicate the implementation. Causes are the four named lazy facades (17,006 B), 828 B of moved-source normalization, and the explicit W2/host-file seam; the 646 B superseded Vega plugin is deleted. The rejected smaller designs were retaining host-file exports inhost-kit/file(the measured eager regression) and using a blanket R13 dynamic/type-only allowance (the structural escape); neither is present.b5dd30fdd2were green, including Coverage, Repo Guards, Integration Tests, Bundle Size, and Android/iOS/macOS/Linux smoke. After the conflict-resolution rebase onto currentmain, fresh checks for4eec054598are running; GitHub remains authoritative for native, device, provider, and live-web lanes. Exact-head live HarmonyOS/Vega/Web provider evidence is not available locally and is not claimed.Evidence status: addressed fixes are pushed and the PR remains open for review; the pre-rebase exact-head checks were green and the rebased exact-head run is pending, while combined-family and live provider/device proof remain outstanding. Do not merge from local evidence alone.