You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
replace the bespoke Oxlint JSON configuration with @nkzw/oxlint-config
retain only active repository-specific environment, import-boundary, generated-script, React test-app, and wire-hash exceptions
apply the newly enabled safe fixes across the repository and teach affected-check/Fallow ownership about the new tooling config
remove inactive type-aware rules and stale configuration discovered during review, and move the child-process boundary to its current host-kit owner
Validation
pnpm format, pnpm lint, and pnpm typecheck
planted lint probes: undefined script globals and direct node:child_process imports fail at the intended boundaries
focused affected-selector suite: 62/62 passed
isolated replay transaction scenario: 17/17 passed after an unrelated teardown-only broad-run failure
pnpm check:affected --run at 42b3378: all runnable checks passed, including 974 files and 7,403 graph-selected tests
exact-head GitHub CI is in progress; GitHub remains authoritative for native, device, coverage, and other CI-only lanes
Scope
218 files changed. The broad source touch set is the safe-fix output required by the lint-policy migration. No docs or skills changed because command behavior is unchanged.
Re-reviewed 1ec581dc. The shared config is the right owning seam and the broad safe-fix delta appears mechanically behavior-neutral; exact-head lint, guards, type/package, integration, coverage, compatibility, CodeQL, and mutation lanes are green, with only +441 B npm unpacked.
P2 lint-boundary tightening:oxlint.config.ts enables browser globals for the entire repository, whereas the prior config declared only Node/ES globals and this head has no production browser-global use. Scope browser: true to the actual browser/test-app files (or remove it) so accidental window/document usage in daemon/CLI code remains lint-visible.
The failed iOS Smoke fill ended in TEXT_INPUT_COMMIT_NOT_OBSERVED; the touched FormScreen changes are property/prop ordering and equivalent entity spelling, so I found no causal path, but the required lane needs a green rerun before readiness.
Addressed in 031a697. Browser globals are now scoped to the test app, and TypeScript no-undef is re-enabled so window/document remain lint-visible in daemon and CLI code. I also compared the resolved old config with the shared preset and restored the project-specific no-unused-vars policy plus every legacy correctness rule the preset did not already cover; deprecated typescript/no-var-requires is covered by typescript/no-require-imports. Planted boundary probes confirmed production browser globals and node:child_process imports fail, while the intended test and browser exceptions pass. pnpm check:affected --run is green locally; exact-head CI, including a fresh iOS Smoke run, is now in progress.
Re-reviewed exact head 031a697846618209a800698d3b75586f59a8ff9e. The prior browser-environment P2 is fixed: browser globals are scoped to the example app, project lint boundaries and no-undef are restored, and the explicit build globals are narrowly declared. I found no remaining code/config issue. All completed checks are green; the remaining mutation/smoke lanes are still running. Code is ready for human review; CI remains authoritative.
Reconciled the additional review in 42b3378. Removed the 15 type-aware rules that are inactive without oxlint-tsgolint/--type-aware; kept the three TypeScript rules that are active. Narrowed no-undef to scripts, where it supplements incomplete tsc coverage, and removed the resulting browser/build-global overrides. Updated the child-process restriction and exception from the retired capture-kit path to @agent-device/host-kit/command and packages/host-kit/src/internal/exec.ts. Removed the deleted .oxlintrc.json from ROOT_TOOLING and dropped the two zero-violation Perfectionist opt-outs. Planted probes confirmed undefined script globals and direct child-process imports in src/host-kit production fail. The full pnpm check:affected --run rerun passed all runnable checks, including 974 files / 7,403 tests. The PR body now reflects exact head 42b3378; exact-head CI is running.
Re-reviewed exact head 42b3378. The latest delta only removes duplicated shared Oxlint config and stale affected-check ownership; no code/config finding. All completed checks are green, and ready-for-human remains justified. iOS Smoke plus two mutation cells are still running, so CI remains authoritative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Scope
218 files changed. The broad source touch set is the safe-fix output required by the lint-policy migration. No docs or skills changed because command behavior is unchanged.