fix(auth): enforce password bounds, key expiry, and exact node-host binding#3081
Open
xilosada wants to merge 1 commit into
Open
fix(auth): enforce password bounds, key expiry, and exact node-host binding#3081xilosada wants to merge 1 commit into
xilosada wants to merge 1 commit into
Conversation
- enforce the configured min/max password length; derive the key id with a salted KDF instead of an unsalted hash - add key expiry (expires_at); a key past its expiry is treated as invalid (absent expiry means non-expiring, preserving existing keys) - node binding uses an exact host comparison and fails closed when the request carries no host/origin
chefsale
approved these changes
Jul 1, 2026
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
frdomovic
changed the title
Member
|
bump — still relevant. Closes security-review items 4 (salted-KDF key id), 17 (password bounds), 18 (key expiry), and 7/20 (exact node-host binding, fail-closed). Independent off master. Note: overlaps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
expires_at); a key past its expiry is treated as invalid (absent expiry means non-expiring, preserving existing keys).Independent of the other auth PRs.
Tests
cargo test -p mero-authgreen (86 passed).