High level logging#25
Closed
chandlerNick wants to merge 6 commits into
Closed
Conversation
philipp-jung
reviewed
Jan 2, 2026
philipp-jung
left a comment
philipp-jung
left a comment
Collaborator
There was a problem hiding this comment.
I think it makes sense to spilt the PR into two - one for the __str__ and __repr__, and another for create_errors_with_config().
I think I don't understand the reason for create_errors_with_config() - what's the reason one would use it instead of create_errors()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add str and repr methods for error mechanisms
Add a function in
high_level.pyto return the config used in the erroringAdd a file
object_oriented.pythat exposes an object oriented (as opposed to the current functional) API.