Fix Issue where High-Level API using ECAR with Given Seed Generated all Errors in the Same Columns#23
Merged
Merged
Conversation
Signed-off-by: Sebastian Jäger <git@sebastian-jaeger.me>
Signed-off-by: Sebastian Jäger <git@sebastian-jaeger.me>
…ored rows for ECAR. Signed-off-by: Sebastian Jäger <git@sebastian-jaeger.me>
Signed-off-by: Sebastian Jäger <git@sebastian-jaeger.me>
Signed-off-by: Sebastian Jäger <git@sebastian-jaeger.me>
chandlerNick
requested changes
Dec 10, 2025
chandlerNick
left a comment
chandlerNick
left a comment
Contributor
There was a problem hiding this comment.
I think we discussed the usage of a generator vs a random seed in March for the lines 257/258 in high_level.py (the source of the mypy errors) and decided that it would be fine to use the overall seed.
Also maybe pin the versions of the dependencies in the pyproject.toml as to not let pandas continue updating while tab-err may stay still.
The checks and actions need to pass before I can approve.
Signed-off-by: Sebastian Jäger <git@sebastian-jaeger.me>
se-jaeger
force-pushed
the
fix_seed_issue
branch
from
December 10, 2025 10:43
db0bae8 to
344b4a5
Compare
chandlerNick
approved these changes
Dec 17, 2025
chandlerNick
left a comment
chandlerNick
left a comment
Contributor
There was a problem hiding this comment.
Looks good, the versions are fine and the change to the random generator is sensible. All tests pass so I approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed fix to the above mentioned issue uses the given seed to setup a random generator, which is used to sample seeds for
ErrorTypes andErrorMechanisms. This way, everything is still deterministic but the errors are distributed over the entire table and not clumped together in certain rows.