Skip to content

minor performance improvement #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manne wants to merge 2 commits into
base: master
Choose a base branch
from
Open

minor performance improvement #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e63c283
minor performance improvement
manne Jul 28, 2018
ab2b6c5
changes visual studio version to 2017 to use c# 7 features
manne Jul 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 5 additions & 21 deletions Source/Cake.Paket.Module/PaketPackageInstaller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,24 +22,9 @@ public sealed class PaketPackageInstaller : IPackageInstaller
/// <param name="log">The log.</param>
public PaketPackageInstaller(ICakeEnvironment environment, INuGetContentResolver contentResolver, ICakeLog log)
{
if (environment == null)
{
throw new ArgumentNullException(nameof(environment));
}

if (contentResolver == null)
{
throw new ArgumentNullException(nameof(contentResolver));
}

if (log == null)
{
throw new ArgumentNullException(nameof(log));
}

Environment = environment;
ContentResolver = contentResolver;
Log = log;
Environment = environment ?? throw new ArgumentNullException(nameof(environment));
ContentResolver = contentResolver ?? throw new ArgumentNullException(nameof(contentResolver));
Log = log ?? throw new ArgumentNullException(nameof(log));
}

private INuGetContentResolver ContentResolver { get; }
Expand Down Expand Up @@ -117,10 +102,9 @@ private static DirectoryPath GetFromGroup(DirectoryPath path, PackageReference p
const string packages = "packages";

var parameters = package.Parameters;

if (parameters.ContainsKey(key))
if (parameters.TryGetValue(key, out var parameter))
{
var group = parameters[key].Single();
var group = parameter.Single();
var folders = path.Segments;
var newFolders = new List<string>();
foreach (var f in folders)
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
image: Visual Studio 2015
image: Visual Studio 2017

environment:
githubPassword:
Expand Down