chore(scripts): remove obsolete Slack OBO verifier - #2460
Draft
kevkantes wants to merge 1 commit into
Draft
Conversation
Signed-off-by: kevkantes <kkantesa@cisco.com>
Contributor
|
✅ No proprietary content detected. This PR is clear for review! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
NEEDS DISCUSSION
@sriaradhyula, this removes the one-off live Slack OBO verifier you introduced in #1401. Please confirm there is no remaining operator workflow that depends on it.
Description
Removes only
scripts/verify-slack-obo.sh. The script has no current caller in CI, Make, Compose, Helm, source, or supported documentation; its sole external reference is the historical Spec 102 task list being removed by #2454.The live Slack OBO implementation remains supported and unit-tested in
ai_platform_engineering/integrations/slack_bot/utils/obo_exchange.py. The deleted helper is not aligned with the current exchange contract because it omits the requiredaudienceparameter and does not validate the minted token audience.Related: #2444 (reference only; this PR does not close it).
Type of Change
Checks
git diff --check main...HEADdocs/docs/specs/102-comprehensive-rbac-tests-and-completion/tasks.md, a historical file retired by draft chore(repo): retire Spec Kit workflow and historical specs #2454Checklist
mainkevkantes <kkantesa@cisco.com>