Center map on home and fit route bounds - #7
Merged
Merged
Conversation
- Initialize map at home coordinates when logged in, avoiding a visible jump on page load - Pre-load session and home location before mounting the map component - On login/user switch, jump to the user's home location instantly - When computing a route, fit the map to show both origin and destination with a short animated transition - Use LngLatBounds.extend() to avoid antimeridian wrapping bug with the two-argument constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
createMap()now accepts optionalcenter/zoomparams.App.svelteawaitscheckSession()+loadHomeLocation()before rendering the<Map>component, passing the home coordinates through.For route fitting, uses
LngLatBounds.extend()instead of the two-argument constructor to avoid a MapLibre bug where SW longitude > NE longitude is interpreted as antimeridian wrapping, causing the map to zoom out to show the entire globe.Test plan