caddyhttp: honor grace period on config reload - #8082
Open
faiyazrahmann wants to merge 1 commit into
Open
faiyazrahmann wants to merge 1 commit into
faiyazrahmann wants to merge 1 commit into
Conversation
faiyazrahmann
force-pushed
the
fix-grace-period-reload
branch
from
September 29, 2026 09:27
cf724ff to
ad004de
Compare
steadytao
requested changes
Sep 30, 2026
keep the grace period context alive until the old servers finish shutting down, and close any connections that are still open once the grace period is over. Signed-off-by: Faiyaz Rahman <faiyazrahman03@gmail.com>
faiyazrahmann
force-pushed
the
fix-grace-period-reload
branch
from
September 30, 2026 12:11
ad004de to
25b297f
Compare
Contributor
Author
|
@steadytao pushed the revision. i added a 10s limit on the cleanup context, just a heads up in case you want a different number or want it configurable... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8078
On a config reload the grace period was skipped entirely. The old serverswere told to shut down and their deadline was cancelled at the same moment,so every reload logged:
This fixes three issues:
Tests cover in-flight requests during reload for HTTP/1.1, HTTP/2, and HTTP/3. They verify requests finish within the grace period and are closed when it expires.
LLM was used to generate in code comments.