Repository navigation
feat: add native async provider API - #508
Open
domenkozar wants to merge 1 commit into
Open
domenkozar wants to merge 1 commit into
domenkozar wants to merge 1 commit into
Conversation
🔍 Suggested ReviewersBased on git blame analysis of the changed lines, the following contributors have significant experience with the modified code: Please consider reviewing this PR as you have authored significant portions of the code being modified. Your expertise would be valuable! 🙏 This comment was automatically generated by git-blame-auto-reviewer Last updated: 2026-10-26T22:42:28.571Z |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
secretspec | 728188d | Commit Preview URL Branch Preview URL |
Oct 26 2026, 10:42 PM |
domenkozar
force-pushed
the
feat/async-provider
branch
from
October 26, 2026 22:36
8b506ae to
11ed0db
Compare
domenkozar
force-pushed
the
feat/async-provider
branch
from
October 26, 2026 22:42
11ed0db to
728188d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async libraries currently have to call SecretSpec's synchronous provider interface, even when a backend already uses an async SDK. Add an object-safe
AsyncProvidertrait and let each backend implement its native storage interface once. The existingProvider,Secretsresolver, and CLI interfaces remain compatible.AsyncProviderand sharedProviderBasefor configuration, credentials, capabilities, naming, and identity. Their handwritten synchronous storage bridges are removed.SyncProviderAdapterfor the synchronous registry. Existing synchronous backends useAsyncProviderAdapterand Tokio's blocking pool when called asynchronously.ExternalProviderfacade, withas_async()andinto_async()access to its native backend. Document cancellation behavior for started blocking operations.Validation:
--no-default-features.Closes #503.