Repository navigation
feat(bw): support session provider credentials - #506
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitwarden Password Manager currently requires an inherited
BW_SESSION, even though SecretSpec can load other providers' credentials from another store. Add asessioncredential so an alias can retrieve it from keyring or another provider:The configured session takes precedence over
BW_SESSIONand is passed only tobwsubprocesses, including status checks, reads, creates, and edits. Missing, empty, or invalid configured credentials fail without using the environment fallback. Existing environment-based authentication continues to work. Login and unlock remain managed by the user.Register the credential, update the shared documentation catalog and provider guide with the 0.22 minimum version, and add a user-facing changelog entry. Tests cover credential precedence, byte preservation, mutation paths, and exclusion of the retrieved session from the application environment.
Fixes #505.
Validation:
Implemented with Codex assistance.