Skip to content

Fix IPC text writes corrupting X.509 identities - #493

Merged
domenkozar merged 1 commit into
mainfrom
fix/ipc-x509-identity-text-writes
Oct 16, 2026
Merged

domenkozar merged 1 commit into
mainfrom
fix/ipc-x509-identity-text-writes

Conversation

@domenkozar

Copy link
Copy Markdown
Member

resolver.set treated encoded X.509 identity text as raw archive bytes. Unprotected identities were rejected, while password-bound identities were double-encoded and overwrote valid stored archives despite reporting success. Subsequent reads failed.

Decode IPC text using the same typed-input handling as set_text. Add regression tests for protected and unprotected archive round trips, CRLF normalization, and invalid input leaving the stored archive intact. Include an unreleased changelog entry.

Follow-up to #483.

Validation:

  • Both new identity regression tests passed.
  • All 10 existing IPC resolver tests passed.
  • Formatting and whitespace checks passed.
  • Package Clippy completed with existing warnings; strict -D warnings fails on those pre-existing warnings with Rust 1.97.
  • Repository commit hooks passed, including workspace Clippy and rustfmt with the pinned Rust 1.92 toolchain.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
secretspec 4f1411c Commit Preview URL

Branch Preview URL
Oct 16 2026, 02:09 PM

@domenkozar
domenkozar merged commit e2c0873 into main Oct 16, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant