Repository navigation
Fix 0.21 release review findings - #453
Merged
Merged
Conversation
secretspec now depends on secretspec-ipc, which was never published, so the release workflow publishes it first and the release docs cover its manual first publish. libsecretspec accepts inline spec v1 again so 0.20 SDKs keep working against a 0.21 library; SDK docs now describe v2. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Oversized prompt answers leave the prompt open, close no longer reports PROMPT_PENDING for its own shutdown, prompts parented on initialize are protocol errors, yyjson documents use a zeroing allocator, the CMake pc file handles absolute install dirs, MSVC static and import libraries no longer collide, and Windows discovery searches only absolute PATH entries. Generated private keys no longer escape zeroization. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Import collision checks fold case and UUID spelling and list the vault once. Unknown UUID refs fail instead of creating items. Single reads agree with batch reads for non-ASCII names. claude login and the helper ignore the ambient SECRETSPEC_PROVIDER so they resolve the same store. gopass only uses the binary cat fallback for base64 entries. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
All reqwest based providers use connect and request timeouts. Setec IPv6 hosts are bracketed once and delete works without the info grant. Doppler retries at the capped delay when Retry-After exceeds it. Dead code warnings under reduced feature sets are gated, and CI checks more features alone. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brokered keyring credentials include the configured URI, endpoints receive a base environment plus variables their claim declares, credential prompts hold no provider lock and get the interactive deadline, Drop no longer panics on a current_thread runtime, and cache planning does not launch the endpoint. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Frame reads keep partial frames across cancellation, SSH tolerates OpenSSH before 8.7, launched children die with their session, Debug output redacts secret values, cancelled starts leave no pending entries, and buffers grow without leaving unwiped copies. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Adds a Changed section for breaking changes, folds fixes to unreleased features into their entries, moves the project default provider chain entry out of the released 0.20.0 section, and restores the INI extract label. Fixes the serve anchor and the Doppler landing label, and gates a CLI-only helper. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
secretspec | 6385021 | Commit Preview URL Branch Preview URL |
Sep 23 2026, 12:12 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found during a pre-release review of everything since v0.20.0.
Release blockers
publish.ymlpublishessecretspec-ipcbeforesecretspec. It has never been on crates.io, so its first publish must be done by hand with a token before tagging 0.21 (seeRELEASE.md).Fixes (each commit is one slice)
.pcabsolute dirs; MSVC static/import lib name clash; Windows PATH-only discovery. Generated private keys no longer escape zeroization.claude loginand the helper resolve the same provider; the gopass binary fallback only applies to base64 entries.infogrant; Doppler retries whenRetry-Afterexceeds the cap; dead code warnings gated; CI checks more features on their own.current_threadruntime; planning no longer launches the endpoint.getnewline, Rust API); fixes to unreleased features are folded into their entries; the misfiled 0.20.0 entries are fixed;serveanchor and Doppler landing label corrected. SDK documentation labels inline schema v2 as requiring SecretSpec 0.21+.Not fixed / needs attention
Testing
cargo test --allpasses (2027 tests), C resolver tests pass under Meson and CMake (including ASan/UBSan), and clippy and rustfmt passed on the earlier Rust commits. The follow-ups passed all five CMake C tests, the docs build, andgit diff --check. Native Windows CI passed bothcargo testand the standalone C build and tests after the allocator fix.This PR was created by Claude Code; see cli/cli#13904.
The shutdown, inline-schema, and MSVC follow-up commits were prepared with Codex.
🤖 Generated with Claude Code