You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
secretspec-ipc/src/client.rs and server.rs effectively ignore unknown notification methods after envelope parsing.
This leaves independent implementations unable to know whether an unknown notification should be ignored, produce diagnostics, or terminate the session.
Suggested resolution
Prefer normal JSON-RPC notification semantics:
Keep the notification envelope structurally strict (jsonrpc, method, params; no unknown top-level members).
Ignore an unknown notification method because it has no response channel.
Continue ignoring unknown/completed cancellation IDs and malformed rpc.cancel parameters as already documented.
Remove the statement that unknown notification methods are protocol-fatal, or explicitly choose the opposite behavior and make code/schema agree.
Explain how future notification methods are capability-gated even when older receivers ignore them.
Deterministic coverage
Add conformance cases for:
unknown notification method;
unknown top-level notification member;
malformed rpc.cancel params;
cancellation for unknown and terminal IDs;
a valid request after each ignored notification case to prove whether the session remains usable.
Activity
fix(ipc): close callback and conformance gaps
fix(ipc): close callback and conformance gaps
domenkozar commentedon Sep 14, 2026
Implemented and tested in 08edfe2. The IPC wire documentation, reference implementation, and conformance coverage now address this issue.
fix(ipc): close callback and conformance gaps