fix(build): pin Go toolchain to go1.26.4 for stdlib vuln patches#25
Merged
Conversation
Addresses GO-2026-5039 (net/textproto) and GO-2026-5037 (crypto/x509), both fixed in go1.26.4. The release builds via `go-version-file: go.mod`, so pinning the toolchain here ensures published binaries link the patched standard library. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pins the build toolchain to
go1.26.4via atoolchaindirective ingo.mod.Why
govulncheck(run under the repo's pinned toolchain) reports two Go standard-library vulnerabilities present in go ≤ 1.26.3:net/textproto: arbitrary inputs included in errors without escaping (reached viaplane.Client.UploadAttachmentBlob→textproto.Reader.ReadMIMEHeader).crypto/x509: inefficient candidate hostname parsing (reached viaUploadAttachmentBlob→x509verification).Both are fixed in go1.26.4. The release workflow builds binaries with
actions/setup-go@v6usinggo-version-file: go.mod, so pinning the toolchain here guarantees published artifacts link the patched standard library. (CI's dedicatedgovulncheckjob already pins 1.26.4, which is why the merged Dependabot PRs stayed green — but the release build itself did not.)Verification
just cipasses end-to-end, includinggovulncheck→ No vulnerabilities found.tools/listsmoke returns the expected 23 tools.🤖 Generated with Claude Code