chore(cloud): drop /cloud path and Cloud factory - #496
Merged
Conversation
The `/cloud` subpath and the top-level `cloud()` factory on `CharlesClient` had no remaining live consumers. charles-cloud-ui (the only real downstream) was deprecated; charles-flowbuilder and charles-client-accounts-api never imported it; charles-agent-ui had two type imports of `/cloud/entities/products` that were actually incorrect (pointing at the admin-level `api/v0/products` entity rather than the catalog `Product`), fixed separately in the agent-ui repo. Removes: - `src/cloud/` (all entities + Cloud class) - `Cloud`, `CloudOptions`, `ICloudFactoryOptions` exports from charles.ts - `CharlesClient.cloud()` factory method
There was a problem hiding this comment.
No issues found across 27 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant UI as Consumer (Agent UI / Cloud UI)
participant SDK as CharlesClient
participant Cloud as Cloud Service (src/cloud)
participant Universe as Universe Service (src/universe)
participant API as Backend API (v0)
Note over UI,API: The PR removes the entire Cloud management sub-system from the SDK
UI->>SDK: instantiate()
rect rgb(200, 50, 50, 0.1)
Note right of SDK: DELETED: src/cloud sub-path
UI-->>SDK: CHANGED: cloud() factory removed
SDK-->>UI: Throws or Mismatch (if still called)
end
alt Previous Product Flow (Agent UI)
UI->>Cloud: CHANGED: product() (Cloud Entity)
Note right of Cloud: Modelled admin api/v0/products
Cloud->>API: GET /api/v0/products
API-->>UI: Admin Resource Data
else NEW: Corrected Product Flow (Agent UI)
UI->>Universe: NEW: product() (Universe Entity)
Note right of Universe: Real runtime product data
Universe->>API: GET /api/v0/universes/{id}/products
API-->>UI: Runtime Product Data
end
Note over UI,Cloud: Flow for Organization/Release/WABA management
UI-->>SDK: CHANGED: All cloud-level entity factories removed
opt Initialization
SDK->>SDK: CHANGED: Removed CloudSingleton setup
end
UI->>Universe: REMAINS: universe()
Universe->>API: Existing universe interactions
API-->>UI: Universe resources (Messages, etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/cloud/entirely — theCloudclass, its 13 entities, and thecloud()factory onCharlesClient.Summary by cubic
Removes the deprecated
/cloudsubpath and thecloud()factory fromCharlesClientto simplify the SDK. Drops theCloudclass and all related entities; no live consumers remain after the linkedagent-uifix.src/cloud/(all entities and theCloudclass).Cloud,CloudOptions,ICloudFactoryOptionsexports andCharlesClient.cloud()fromsrc/charles.ts.Written for commit bb15230. Summary will update on new commits.