Skip to content

chore(cloud): drop /cloud path and Cloud factory - #496

Merged
tobias-goertz merged 1 commit into
masterfrom
chore/drop-cloud-path
Apr 23, 2026
Merged

chore(cloud): drop /cloud path and Cloud factory#496
tobias-goertz merged 1 commit into
masterfrom
chore/drop-cloud-path

Conversation

@tobias-goertz

@tobias-goertz tobias-goertz commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Removes src/cloud/ entirely — the Cloud class, its 13 entities, and the cloud() factory on CharlesClient.

Summary by cubic

Removes the deprecated /cloud subpath and the cloud() factory from CharlesClient to simplify the SDK. Drops the Cloud class and all related entities; no live consumers remain after the linked agent-ui fix.

  • Refactors
    • Deleted src/cloud/ (all entities and the Cloud class).
    • Removed Cloud, CloudOptions, ICloudFactoryOptions exports and CharlesClient.cloud() from src/charles.ts.

Written for commit bb15230. Summary will update on new commits.

The `/cloud` subpath and the top-level `cloud()` factory on `CharlesClient` had
no remaining live consumers. charles-cloud-ui (the only real downstream) was
deprecated; charles-flowbuilder and charles-client-accounts-api never imported it;
charles-agent-ui had two type imports of `/cloud/entities/products` that were
actually incorrect (pointing at the admin-level `api/v0/products` entity rather
than the catalog `Product`), fixed separately in the agent-ui repo.

Removes:
- `src/cloud/` (all entities + Cloud class)
- `Cloud`, `CloudOptions`, `ICloudFactoryOptions` exports from charles.ts
- `CharlesClient.cloud()` factory method

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 27 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.
Architecture diagram
sequenceDiagram
    participant UI as Consumer (Agent UI / Cloud UI)
    participant SDK as CharlesClient
    participant Cloud as Cloud Service (src/cloud)
    participant Universe as Universe Service (src/universe)
    participant API as Backend API (v0)

    Note over UI,API: The PR removes the entire Cloud management sub-system from the SDK

    UI->>SDK: instantiate()
    
    rect rgb(200, 50, 50, 0.1)
        Note right of SDK: DELETED: src/cloud sub-path
        UI-->>SDK: CHANGED: cloud() factory removed
        SDK-->>UI: Throws or Mismatch (if still called)
    end

    alt Previous Product Flow (Agent UI)
        UI->>Cloud: CHANGED: product() (Cloud Entity)
        Note right of Cloud: Modelled admin api/v0/products
        Cloud->>API: GET /api/v0/products
        API-->>UI: Admin Resource Data
    else NEW: Corrected Product Flow (Agent UI)
        UI->>Universe: NEW: product() (Universe Entity)
        Note right of Universe: Real runtime product data
        Universe->>API: GET /api/v0/universes/{id}/products
        API-->>UI: Runtime Product Data
    end

    Note over UI,Cloud: Flow for Organization/Release/WABA management
    UI-->>SDK: CHANGED: All cloud-level entity factories removed
    
    opt Initialization
        SDK->>SDK: CHANGED: Removed CloudSingleton setup
    end

    UI->>Universe: REMAINS: universe()
    Universe->>API: Existing universe interactions
    API-->>UI: Universe resources (Messages, etc.)
Loading

@tobias-goertz
tobias-goertz merged commit 9d40bcc into master Apr 23, 2026
2 checks passed
@tobias-goertz
tobias-goertz deleted the chore/drop-cloud-path branch April 23, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant