Skip to content

Feat/campaign scheduling - #305

Open
haayhappen wants to merge 1 commit into
masterfrom
feat/campaign-scheduling
Open

Feat/campaign scheduling#305
haayhappen wants to merge 1 commit into
masterfrom
feat/campaign-scheduling

Conversation

@haayhappen

Copy link
Copy Markdown
Contributor

Enables scheduling campaign publishes

@codecov

codecov Bot commented Mar 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #305 (de4d8c5) into master (bb4e041) will increase coverage by 0.69%.
The diff coverage is 43.58%.

❗ Current head de4d8c5 differs from pull request most recent head f34dc52. Consider uploading reports for the commit f34dc52 to get more accurate results

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   33.41%   34.10%   +0.69%     
==========================================
  Files         115      128      +13     
  Lines        8644    10329    +1685     
  Branches     2250     2658     +408     
==========================================
+ Hits         2888     3523     +635     
- Misses       5318     6806    +1488     
+ Partials      438        0     -438     
Impacted Files Coverage Δ
src/analytics/analytics.ts 50.00% <ø> (ø)
src/cloud/index.ts 36.08% <0.00%> (ø)
src/realtime/index.ts 24.09% <ø> (ø)
src/v0/auth.ts 89.65% <ø> (ø)
src/entities/person/person-contact.ts 16.12% <16.12%> (ø)
src/cloud/entities/organization/organization.ts 22.85% <18.36%> (-6.46%) ⬇️
src/cloud/entities/universe/universe.ts 22.11% <19.54%> (-4.55%) ⬇️
...ies/notification-campaign/notification-campaign.ts 22.47% <24.80%> (-1.31%) ⬇️
src/eventing/feeds/feed.ts 20.53% <25.00%> (-0.59%) ⬇️
src/entities/notification-campaign/static-entry.ts 25.31% <25.31%> (ø)
... and 82 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@david-gregorian david-gregorian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just needs a minor message fix

Comment thread src/entities/notification-campaign/notification-campaign.ts Outdated
fix(package): nail typescript

fix(tests): fix ts issues
@amgadserry
amgadserry force-pushed the feat/campaign-scheduling branch from 93d624e to f34dc52 Compare April 6, 2023 09:34
@patrick-petrovic
patrick-petrovic removed their request for review August 7, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants