Skip to content

Add Strava segment service with Segment and Segments endpoints#37

Open
Copilot wants to merge 7 commits into
mainfrom
copilot/add-segment-service
Open

Add Strava segment service with Segment and Segments endpoints#37
Copilot wants to merge 7 commits into
mainfrom
copilot/add-segment-service

Conversation

Copilot AI commented May 18, 2026

Copy link
Copy Markdown
Contributor
  • Inspect current WithDateRange definition, call sites, and baseline validation state
  • Move WithDateRange into /home/runner/work/activity/activity/strava/strava.go and remove the old definition from activity.go
  • Verify imports and existing tests still reflect the shared API option location
  • Run gofmt, go test ./..., and golangci-lint run after the move

Agent-Logs-Url: https://github.com/bzimmer/activity/sessions/ccc18ea0-b8c4-430f-80bc-55da6436f2da

Co-authored-by: bzimmer <12852+bzimmer@users.noreply.github.com>
@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.69%. Comparing base (897fb10) to head (23b9c8a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   81.94%   82.69%   +0.74%     
==========================================
  Files          35       36       +1     
  Lines        1429     1479      +50     
==========================================
+ Hits         1171     1223      +52     
+ Misses        144      143       -1     
+ Partials      114      113       -1     
Files with missing lines Coverage Δ
strava/activity.go 70.05% <ø> (-1.53%) ⬇️
strava/encoding.go 87.34% <100.00%> (ø)
strava/segment.go 100.00% <100.00%> (ø)
strava/strava.go 84.37% <100.00%> (+7.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897fb10...23b9c8a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI and others added 2 commits May 18, 2026 06:54
Copilot AI requested a review from bzimmer May 18, 2026 07:01
@bzimmer bzimmer marked this pull request as ready for review May 18, 2026 07:02
Agent-Logs-Url: https://github.com/bzimmer/activity/sessions/b9bedb45-f923-4550-bb40-edcfde0d87fb

Co-authored-by: bzimmer <12852+bzimmer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bzimmer/activity/sessions/408adeab-1457-497c-aca4-85f52b5e20cc

Co-authored-by: bzimmer <12852+bzimmer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bzimmer/activity/sessions/45c0cbe1-768e-45f3-996b-21cc4798ea3a

Co-authored-by: bzimmer <12852+bzimmer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants