fix(remote): hub path quoting and Windows SCP merge for satellite push - #6
Open
andrew05060414 wants to merge 3 commits into
Open
fix(remote): hub path quoting and Windows SCP merge for satellite push#6andrew05060414 wants to merge 3 commits into
andrew05060414 wants to merge 3 commits into
Conversation
Shell-escape remote database paths for file_exists, SCP, and path expansion so satellite push fetches the hub before merging. Document database_path and serial push requirements for Win/Mac NAS satellites.
Pass SCP remote paths as a single argv element (no shell quotes on Windows). Abort push when a fetched hub file is unexpectedly small. Keeps SSH shell quoting for file_exists and path expansion.
Document satellite push merge behavior, database_path, spaced paths, and verification. Link from README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
database_pathcontains spaces (SSHtest -f/eval echoquoting)host:'/path'quoting)docs/remote-sync.mdand link from READMEDepends on
mainfor review, butsync_to_remoteexpectsdevice_namespacefrom that change)Test plan
cargo test -p hstry-core remote::tests