Modification of setFormat for VideoInputFrameGrabber - #2107
Open
Zjaun wants to merge 2 commits into
Open
Conversation
Member
|
The values of that look more like video codecs, so we could maybe pick the value from videoCodec instead? |
Author
|
I based my changes only in |
Member
|
It's in the FrameGrabber class.
|
Member
So that you could call |
Author
|
Oohh, a new function (I guess) that is not implemented directly in the |
Member
|
No need to add new methods, just use the value of the videoCodec field variable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the current implementation of
VideoInputFrameGrabberdoes nothing, I modified the statements inside thestart()method of the class. In this change, developers can now set the format/subtype of that FrameGrabber. They can now use MJPEG instead of the default media format.PS: Tried setting the grabber's resolution to 1080p with MJPEG, and the image is black. It's not black if the resolution is lower than that (only happens if you called the grab() method for the first time, the image isn't black after that)