fix: Decoration plugin appendTransaction throw RangeError when resolve - #237
Open
clumsyme wants to merge 1 commit into
Open
fix: Decoration plugin appendTransaction throw RangeError when resolve#237clumsyme wants to merge 1 commit into
clumsyme wants to merge 1 commit into
Conversation
Author
|
@bradwang95 辛苦有空看下修复下这个 bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decoration.fromshould not be greater thantr.doc.content.size, which istr.doc.nodeSize - 2.Otherwise,
tr.doc.resolve(decoration.from)will throw RangeError.This fixes #226 ,where
decoration.fromis 3 andtr.doc.nodeSizeis 4 after deleting all content.