Repository navigation
migrate hickory dns client to 0.26.1 - #1076
Merged
Merged
Conversation
DanielHaimanot
commented
Jun 13, 2026
DanielHaimanot
commented
Collaborator
- Update Hickory client DNS dependencies for 0.26.1 (mitigate DNSSEC advisory)
- Adapt the local client integration to the crate split to hickory-net and hickory-proto
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1076 +/- ##
==========================================
- Coverage 67.70% 67.69% -0.02%
==========================================
Files 1432 1432
Lines 136749 136755 +6
==========================================
- Hits 92590 92578 -12
- Misses 44159 44177 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zh-jq
requested changes
Jun 13, 2026
| fn from(value: NetError) -> Self { | ||
| let driver_error = match &value { | ||
| NetError::Timeout => ResolveDriverError::Timeout, | ||
| NetError::Proto(e) => ResolveDriverError::from(e), |
Collaborator
There was a problem hiding this comment.
NetError::Dns(e) shouldn't be considered as driver error
Collaborator
Author
There was a problem hiding this comment.
Gotcha, tried to add a case for DnsError.
DanielHaimanot
force-pushed
the
bump_hickory
branch
from
June 14, 2026 05:36
eccc155 to
0ffd995
Compare
zh-jq
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.