Repository navigation
fix: icap payload length parsing with atoi FromRadix10 - #1074
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1074 +/- ##
===========================================
+ Coverage 23.36% 67.69% +44.32%
===========================================
Files 637 1432 +795
Lines 42707 136749 +94042
===========================================
+ Hits 9979 92571 +82592
- Misses 32728 44178 +11450
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zh-jq
requested changes
Jun 12, 2026
DanielHaimanot
force-pushed
the
fix/icap_FromRadix10
branch
from
June 12, 2026 04:15
e09712f to
8bd6ebe
Compare
DanielHaimanot
force-pushed
the
fix/icap_FromRadix10
branch
from
June 12, 2026 04:17
8bd6ebe to
507cd2b
Compare
zh-jq
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid using
usize::from_radix_10