Skip to content

fix: icap payload length parsing with atoi FromRadix10 - #1074

Merged
DanielHaimanot merged 1 commit into
masterfrom
fix/icap_FromRadix10
Jun 12, 2026
Merged

DanielHaimanot merged 1 commit into
masterfrom
fix/icap_FromRadix10

Conversation

@DanielHaimanot

Copy link
Copy Markdown
Collaborator

avoid using usize::from_radix_10

@DanielHaimanot
DanielHaimanot requested a review from zh-jq June 12, 2026 03:53
@codecov

codecov Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.69%. Comparing base (0fded21) to head (507cd2b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/g3-icap-client/src/reqmod/payload.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1074       +/-   ##
===========================================
+ Coverage   23.36%   67.69%   +44.32%     
===========================================
  Files         637     1432      +795     
  Lines       42707   136749    +94042     
===========================================
+ Hits         9979    92571    +82592     
- Misses      32728    44178    +11450     
Flag Coverage Δ
g3bench 19.75% <0.00%> (?)
g3keymess 20.76% <ø> (ø)
g3mkcert 26.73% <ø> (ø)
g3proxy 49.91% <66.66%> (?)
g3statsd 5.58% <ø> (ø)
lib 57.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread lib/g3-icap-client/src/reqmod/payload.rs Outdated
@DanielHaimanot
DanielHaimanot merged commit 20141d9 into master Jun 12, 2026
118 of 120 checks passed
@DanielHaimanot
DanielHaimanot deleted the fix/icap_FromRadix10 branch June 12, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants