fix(paimon): improve filter pushdown and preserve remaining filters#679
Open
Weixin-Xu wants to merge 4 commits into
Open
fix(paimon): improve filter pushdown and preserve remaining filters#679Weixin-Xu wants to merge 4 commits into
Weixin-Xu wants to merge 4 commits into
Conversation
1685567 to
c984a0e
Compare
c984a0e to
6114b8f
Compare
Preserve untranslated Paimon filters as remaining filters, fold constant RHS expressions before predicate translation, and support string LIKE predicates. Add translator coverage for remaining filters, constant RHS pushdown, subfield filter round trips, and string LIKE cases.
6114b8f to
5dae07b
Compare
guhaiyan0221
approved these changes
Jul 1, 2026
Reuse the common ExprToSubfieldFilter parser when an evaluator is available and keep the Paimon direct filter path as fallback. Propagate the evaluator through the Paimon scan path and move top-level conjunction flattening into the shared expression filter utilities.
Collect top-level field accesses backed by InputTypedExpr so remaining filters can read non-output columns during Paimon scans. Flatten top-level conjuncts before converting Paimon predicates to subfield filters so evaluator-backed extraction can push down each supported leaf.
03ba1f2 to
bf2135d
Compare
bf2135d to
28d61e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve untranslated Paimon filters as remaining filters, fold constant RHS expressions before predicate translation, and support string LIKE predicates.
Add translator coverage for remaining filters, constant RHS pushdown, subfield filter round trips, and string LIKE cases.
What problem does this PR solve?
Issue Number: close #685
Type of Change
Description
ANDfilters into conjuncts and translate each conjunct independently.ExpressionEvaluatorbefore translating literals.LIKEpredicate support for two-argument LIKE; keep three-argument LIKE with explicit escape as remaining filter.Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes