feat: separate env - #98
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for individual database connection parameters as an alternative to DSN configuration, allowing users to avoid URL encoding issues with special characters in passwords.
- Added
buildDSNFromEnvParams()function to construct DSNs from individual environment variables - Integrated individual parameter support into the existing
resolveDSN()function with proper priority handling - Updated documentation and configuration examples to explain both connection methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/config/env.ts | Added new function to build DSN from individual env vars and integrated it into DSN resolution flow |
| src/config/tests/env.test.ts | Comprehensive test suite covering all database types, edge cases, and integration scenarios |
| README.md | Updated documentation to explain both DSN and individual parameter methods with examples |
| .env.example | Added commented examples showing individual parameter configuration options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tianzhou
force-pushed
the
separate-env
branch
3 times, most recently
from
September 23, 2025 10:09
6b30312 to
c1489ec
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tianzhou
force-pushed
the
separate-env
branch
from
September 23, 2025 10:10
c1489ec to
4f456f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #96