Skip to content

Use Bootstrap 5 classes. - #52

Merged
PhMemmel merged 1 commit into
bycs-lp:mainfrom
lucaboesch:bootstrap5
Apr 23, 2026
Merged

Use Bootstrap 5 classes.#52
PhMemmel merged 1 commit into
bycs-lp:mainfrom
lucaboesch:bootstrap5

Conversation

@lucaboesch

Copy link
Copy Markdown
Contributor

The ml- classes are Bootstrap 4.

@PhMemmel PhMemmel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucaboesch! Thank you very much for finding these. Currently, we're trying to maintain everything in one branch. So could you please keep the bootstrap 4 classes and just add the new ones?

@lucaboesch

Copy link
Copy Markdown
Contributor Author

I think this would be only necessary if tiny_elements were to support Moodle 4.4 and before.
Moodle 4.5 does deal with the 'new' classes well. If I'm not mistaken, what you propose isn't necessary.

@PhMemmel PhMemmel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations. You really made me boot up a moodle 4.5 instance and have a look ;-)

You're right, moodle has integrated these new classes from bootstrap 5 into boost theme in moodle 4.5, they call it "bootstrap 5 bridge".

So the changes are working well in all supported versions.

Thank you for the fix!

@PhMemmel
PhMemmel merged commit f1e3169 into bycs-lp:main Apr 23, 2026
6 of 8 checks passed
@lucaboesch

Copy link
Copy Markdown
Contributor Author

😄

@lucaboesch
lucaboesch deleted the bootstrap5 branch April 23, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants