MBS-10141: remove legacy code - #5
Open
sh-csg wants to merge 1 commit into
Open
Conversation
sh-csg
force-pushed
the
MBS-10141-remove-legacy-code
branch
from
May 15, 2025 07:47
894cada to
2c20948
Compare
sh-csg
force-pushed
the
MBS-10141-remove-legacy-code
branch
from
August 7, 2025 18:59
2c20948 to
03d7e93
Compare
sh-csg
force-pushed
the
main
branch
2 times, most recently
from
August 7, 2025 19:54
35a0cc2 to
2669d7b
Compare
sh-csg
force-pushed
the
MBS-10141-remove-legacy-code
branch
from
August 8, 2025 05:49
03d7e93 to
8272323
Compare
fhuebler
self-requested a review
September 29, 2025 09:13
fhuebler
requested changes
Sep 29, 2025
| @@ -70,7 +70,7 @@ public function import(\stored_file|string $zip, int $draftitemid = 0): void { | |||
| $fp->extract_to_storage($zip, $this->contextid, 'tiny_elements', 'import', $draftitemid, '/'); | |||
| $xmlfile = $fs->get_file($this->contextid, 'tiny_elements', 'import', $draftitemid, '/', constants::FILE_NAME_EXPORT); | |||
| if (!$xmlfile) { | |||
Contributor
There was a problem hiding this comment.
Hoppla now there is if (!$xmlfile) { twice
Contributor
There was a problem hiding this comment.
still there:
$xmlfile = $fs->get_file($this->contextid, 'tiny_elements', 'import', $draftitemid, '/', constants::FILE_NAME_EXPORT);
if (!$xmlfile) {
throw new moodle_exception(get_string('error_import_missing_xml', 'tiny_elements'));
}
if (!$xmlfile) {
throw new moodle_exception(get_string('error_import_missing_xml', 'tiny_elements'));
}
$xmlcontent = $xmlfile->get_content();
sh-csg
force-pushed
the
MBS-10141-remove-legacy-code
branch
from
October 5, 2025 15:27
8272323 to
7c3c9d0
Compare
Contributor
Author
|
Rebased on current main, problems should be solved now. |
sh-csg
force-pushed
the
MBS-10141-remove-legacy-code
branch
from
October 5, 2025 15:32
7c3c9d0 to
52a49b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.