MBS-10904: Allow linebreaks in discussion - #109
Open
sh-csg wants to merge 1 commit into
Open
Conversation
sh-csg
force-pushed
the
MBS-10904-Allow-linebreaks-in-discussion
branch
from
July 8, 2026 05:39
3fe60af to
b5a6459
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the kanban discussion message rendering to preserve user-entered line breaks when discussion content is returned to the frontend.
Changes:
- Bump plugin version to trigger upgrade processing.
- Adjust external return metadata for discussion content (
PARAM_TEXT→PARAM_RAW). - Render discussion content with
format_text(..., ['para' => false, 'context' => ...])plusnl2br()to convert newlines to<br />.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
version.php |
Increments plugin version for upgrade tracking. |
classes/external/get_kanban_content.php |
Updates discussion return type and converts newlines to <br /> in get_discussion_update(). |
classes/boardmanager.php |
Converts newlines to <br /> when adding a discussion message so immediate updates preserve line breaks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
943
to
945
| $update['content'] = format_text($update['content'], FORMAT_HTML, ['para' => false, 'context' => context_module::instance($this->cmid)]); | ||
| $update['content'] = nl2br($update['content']); | ||
| if (!empty($this->kanban->usenumbers) && !empty($this->kanban->linknumbers)) { |
PhMemmel
requested changes
Jul 20, 2026
PhMemmel
left a comment
PhMemmel
left a comment
Member
There was a problem hiding this comment.
Have you taken using format_text(..., FORMAT_PLAIN) into consideration? This feels a little bit straightforward for what you want to achieve here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.