Skip to content

MBS-10872: Show all boards - #108

Open
sh-csg wants to merge 2 commits into
masterfrom
MBS-10872-Show-all-boards
Open

MBS-10872: Show all boards#108
sh-csg wants to merge 2 commits into
masterfrom
MBS-10872-Show-all-boards

Conversation

@sh-csg

@sh-csg sh-csg commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@sh-csg
sh-csg requested a review from Copilot June 15, 2026 10:23
@sh-csg sh-csg self-assigned this Jun 15, 2026
@sh-csg
sh-csg force-pushed the MBS-10872-Show-all-boards branch from 39d45f4 to 10a536e Compare June 15, 2026 10:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an “all boards” view to mod_kanban, allowing authorized users to render multiple boards (shared/personal/group) on the same page, with associated UI and JS updates to support multiple independent reactive instances.

Changes:

  • Add an allboards URL parameter and capability gate to render multiple board containers on view.php.
  • Update templates/CSS to support per-board container IDs and hide the “view all boards” action when already in all-boards mode.
  • Update AMD code to avoid reactive-instance name collisions and to replace inline Mustache modal markup with JS-driven modals for group/user switching.

Reviewed changes

Copilot reviewed 9 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
view.php Adds allboards param handling, capability check, and loops over board IDs to render multiple containers + JS inits
templates/container.mustache Makes container IDs unique per board and adds an allboards CSS class hook
templates/actionmenuboard.mustache Adds “View all boards” action and switches group/user change actions to JS-driven triggers
styles.css Hides the “view all boards” menu item while in all-boards mode
lang/en/kanban.php Adds strings for the new UI entry and informational notice
amd/src/selectors.js Adds selectors for the new action menu triggers
amd/src/main.js Makes reactive instance name unique per (cmId, boardId)
amd/src/exporter.js Refactors group selector/users export into dedicated static helpers
amd/src/board.js Implements Modal-based group/user selection (replacing inline Mustache modal HTML/JS)
amd/build/*.min.js, *.map Rebuilt AMD artifacts reflecting the source changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread view.php
Comment thread view.php

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 17 changed files in this pull request and generated 5 comments.

Comment thread amd/src/board.js
Comment thread amd/src/board.js
Comment thread templates/actionmenuboard.mustache Outdated
Comment thread templates/actionmenuboard.mustache Outdated
Comment thread view.php
@PhMemmel PhMemmel changed the title Mbs 10872 show all boards MBS-10872: Show all boards Jul 7, 2026
@PhMemmel
PhMemmel force-pushed the MBS-10872-Show-all-boards branch from 01d3130 to cc1aee0 Compare July 7, 2026 20:02
@sh-csg
sh-csg force-pushed the MBS-10872-Show-all-boards branch from cc1aee0 to 630df69 Compare July 8, 2026 12:22
@sh-csg
sh-csg requested a review from Copilot July 10, 2026 05:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

Comment thread templates/actionmenuboard.mustache
Comment thread view.php Outdated
Comment thread templates/container.mustache
@sh-csg
sh-csg force-pushed the MBS-10872-Show-all-boards branch from d264156 to 89f36b3 Compare July 13, 2026 04:27
@sh-csg
sh-csg requested a review from Copilot July 13, 2026 04:27
@sh-csg
sh-csg force-pushed the MBS-10872-Show-all-boards branch from 89f36b3 to da70c7d Compare July 13, 2026 04:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.

Comment thread view.php Outdated
Comment thread templates/actionmenuboard.mustache Outdated
@sh-csg
sh-csg force-pushed the MBS-10872-Show-all-boards branch from da70c7d to d583c41 Compare July 13, 2026 04:39
@sh-csg
sh-csg requested a review from Copilot July 13, 2026 04:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.

Comment thread templates/actionmenuboard.mustache
Comment thread view.php
@sh-csg
sh-csg force-pushed the MBS-10872-Show-all-boards branch from d583c41 to ff6a9a6 Compare July 13, 2026 05:42
Comment thread view.php
[
'cmid' => $cm->id,
'id' => $bid,
'cardid' => ($boardid == $bid ? $cardid : 0),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm losing track. In which cases does a boardId appear in the URL? In which cases a cardId?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This handles the case that a cardid is present as a parameter - it is only passed to the board where the card belongs to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants