MBS-10330: Avoid jumping when reloading map - #152
Conversation
7ff270e to
a36d45a
Compare
PhMemmel
left a comment
PhMemmel
left a comment
There was a problem hiding this comment.
Looks good in general.
One comment.
Besides that: Currently, reloading of the learningmap seems to be broken if you mark a completed activity on the course page as "not completed". This behavior does not seem to be caused by this patch, but as the mechanics for loading the learningmap are being touched in this PR it would be nice if this could be fixed as well?
|
|
||
| $mapcontent = null; | ||
|
|
||
| if (!empty($request['methodname']) && $request['methodname'] == 'core_course_get_module') { |
There was a problem hiding this comment.
I've never seen this in the moodle code. Is this stable?
How about using if (AJAX_SCRIPT)? This is being used far more often? Would this be specific enough?
There was a problem hiding this comment.
This wouldn't allow me to handle just this method (as I cannot know what other webservices are doing).
I can't reproduce that here. |
08e4930 to
9c2d47a
Compare
9c2d47a to
75dbdb1
Compare
|
Was by accident merged via #154 , but should be fine |
2 participants
No description provided.