feat(ledger): add deduct_credits and get_history [REN-77] - #111
Merged
Merged
Conversation
…EN-77] Add deduct_credits() with idempotency via reference_id, SELECT FOR UPDATE row locking, and pre-flush InsufficientCreditsError check to prevent negative balances. Add get_history() with limit/offset pagination and silent clamping at max 100 entries. Includes 7 test cases covering basic deduction, idempotency, insufficient funds, invalid amounts, ordering, pagination, and empty results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deduct_credits()service function with idempotency, SELECT FOR UPDATE locking, and customInsufficientCreditsErrorexceptionget_history()for paginated transaction history (limit/offset, max 100)Test plan
test_deduct_credits_basic— allocate 100, deduct 30, verify balance=70test_deduct_credits_idempotent— same reference_id returns existing entrytest_deduct_credits_insufficient— raises InsufficientCreditsErrortest_deduct_credits_zero_or_negative— raises ValueErrortest_get_history_default— created_at DESC orderingtest_get_history_pagination— limit/offset correctnesstest_get_history_empty— returns [] for new user🤖 Generated with Claude Code