Update dependencies, lift panics out of the parsing code into errors - #18
Open
dexwood wants to merge 1 commit into
Open
Update dependencies, lift panics out of the parsing code into errors#18dexwood wants to merge 1 commit into
dexwood wants to merge 1 commit into
Conversation
…that can be handled by the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using the archive2 functionality to pull in real-time radar data and the panics within the code made it to where I couldn't deal with partially created level2 data files. Lifting the panics into errors allows it to be handled by the caller.
I also improved some flow control in the switch statement and updated direct and indirect dependencies. I've been testing the changes for a while and they seem to work well.