Add frappe dependency for frappe cloud bench#183
Conversation
Greptile SummaryAdds Frappe 16 or newer as a Bench-managed dependency for Frappe Cloud bench installation. Confidence Score: 3/5The Frappe dependency range must be bounded before merging because the current declaration blocks the targeted Frappe Cloud installation flow. Frappe Cloud validates custom-app dependency ranges and rejects the newly added single-sided Files Needing Attention: pyproject.toml
|
| Filename | Overview |
|---|---|
| pyproject.toml | Adds an unbounded Frappe dependency declaration that Frappe Cloud rejects during custom-bench validation. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
pyproject.toml:19
**Unbounded range blocks cloud deployment**
Frappe Cloud rejects single-sided dependency ranges during app validation, so `>=16.0.0` prevents this app from being installed when creating the custom bench the change targets. Declare a bounded Frappe version range accepted by the platform.
Reviews (1): Last reviewed commit: "Add frappe dependency for frappe bench" | Re-trigger Greptile
| build-backend = "flit_core.buildapi" | ||
|
|
||
| [tool.bench.frappe-dependencies] | ||
| frappe = ">=16.0.0" |
There was a problem hiding this comment.
Unbounded range blocks cloud deployment
Frappe Cloud rejects single-sided dependency ranges during app validation, so >=16.0.0 prevents this app from being installed when creating the custom bench the change targets. Declare a bounded Frappe version range accepted by the platform.
Prompt To Fix With AI
This is a comment left during a code review.
Path: pyproject.toml
Line: 19
Comment:
**Unbounded range blocks cloud deployment**
Frappe Cloud rejects single-sided dependency ranges during app validation, so `>=16.0.0` prevents this app from being installed when creating the custom bench the change targets. Declare a bounded Frappe version range accepted by the platform.
How can I resolve this? If you propose a fix, please make it concise.
Reference: https://docs.frappe.io/cloud/benches/custom-app#note