Skip to content

Add frappe dependency for frappe cloud bench#183

Open
davidbolla wants to merge 1 commit into
bwhtech:developfrom
davidbolla:patch-1
Open

Add frappe dependency for frappe cloud bench#183
davidbolla wants to merge 1 commit into
bwhtech:developfrom
davidbolla:patch-1

Conversation

@davidbolla

Copy link
Copy Markdown

@greptile-apps

greptile-apps Bot commented Jul 26, 2026

Copy link
Copy Markdown

Greptile Summary

Adds Frappe 16 or newer as a Bench-managed dependency for Frappe Cloud bench installation.

Confidence Score: 3/5

The Frappe dependency range must be bounded before merging because the current declaration blocks the targeted Frappe Cloud installation flow.

Frappe Cloud validates custom-app dependency ranges and rejects the newly added single-sided >=16.0.0 constraint, preventing bench creation or app installation.

Files Needing Attention: pyproject.toml

Important Files Changed

Filename Overview
pyproject.toml Adds an unbounded Frappe dependency declaration that Frappe Cloud rejects during custom-bench validation.

Fix All in Claude Code Fix All in Codex

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
pyproject.toml:19
**Unbounded range blocks cloud deployment**

Frappe Cloud rejects single-sided dependency ranges during app validation, so `>=16.0.0` prevents this app from being installed when creating the custom bench the change targets. Declare a bounded Frappe version range accepted by the platform.

Reviews (1): Last reviewed commit: "Add frappe dependency for frappe bench" | Re-trigger Greptile

Comment thread pyproject.toml
build-backend = "flit_core.buildapi"

[tool.bench.frappe-dependencies]
frappe = ">=16.0.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Unbounded range blocks cloud deployment

Frappe Cloud rejects single-sided dependency ranges during app validation, so >=16.0.0 prevents this app from being installed when creating the custom bench the change targets. Declare a bounded Frappe version range accepted by the platform.

Prompt To Fix With AI
This is a comment left during a code review.
Path: pyproject.toml
Line: 19

Comment:
**Unbounded range blocks cloud deployment**

Frappe Cloud rejects single-sided dependency ranges during app validation, so `>=16.0.0` prevents this app from being installed when creating the custom bench the change targets. Declare a bounded Frappe version range accepted by the platform.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant